Issue 53567: Improve "Alias" column performance #7152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
force-pushed
the
fb_alias_perf_53567
branch
from
bf48dbe to
29a8d35
Compare
| } | ||
| } | ||
| return sb.toString(); | ||
| return String.join(", ", (List) value); |
There was a problem hiding this comment.
I see this isn't new, but I really don't like it. This should be a robustly round-trippable format. In https://docs.google.com/document/d/1oXkzxDD7hIQy9bSp3KQ9pjG69kdcoCoRPRHT4y759fo/edit?tab=t.0#heading=h.xa25n05t4ysx I proposed using the same format Google Sheets uses for multi-choice fields. The closest thing we have is PageFlowUtil.joinValuesToStrin()/splitStringToValues(). But it is not Sheets compatible. We should write a new method maybe PageFlowUtil.joinValuesForExport()/splitValuesForImport().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53567 by refactoring the "Alias" column for data classes and sample types away from the traditional multi-value foreign key (MVFK) to an inline join on the values.
Related Pull Requests
Changes
ColumnInfo.isMultiValued()to allow columns to declare they are multi-value. Formerly, everything needed to be an instance ofMultiValueForeignKey.string_agg()and::text. Reduces per item processing.Tasks