Skip to content

Fix messages "Reset to folder default setting" checkbox #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release25.3-SNAPSHOT
Choose a base branch
from
Open

Fix messages "Reset to folder default setting" checkbox #6816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions announcements/src/org/labkey/announcements/emailPreferences.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/
%>
<%@ page import="org.apache.commons.lang3.StringUtils" %>
<%@ page import="org.labkey.announcements.AnnouncementsController.EmailPreferencesAction" %>
<%@ page import="org.labkey.api.announcements.EmailOption" %>
<%@ page extends="org.labkey.announcements.EmailPreferencesPage" %>
Expand All @@ -24,14 +23,14 @@
<script type="text/javascript" nonce="<%=getScriptNonce()%>">
function toggleOptions()
{
var checkBoxElem = document.getElementById("resetFolderDefault");
const checkBoxElem = document.getElementById("resetFolderDefault");

var isReset = checkBoxElem.checked;
if (checkBoxElem != null)
{
var inputs = document.getElementsByTagName('input');
for(var i = 0; i < inputs.length; i++) {
if(inputs[i].type.toLowerCase() === 'radio') {
const isReset = checkBoxElem.checked;
const inputs = document.getElementsByTagName('input');
for (let i = 0; i < inputs.length; i++) {
if (inputs[i].type.toLowerCase() === 'radio') {
inputs[i].disabled = isReset;
}
}
Expand All @@ -54,8 +53,8 @@
<input type="radio" value="<%=EmailOption.MESSAGES_DAILY_DIGEST.getValue()%>" name="notificationType"<%=checked(notificationType == EmailOption.MESSAGES_DAILY_DIGEST.getValue())%>>
<b>Daily Digest</b> - send one email each day that summarizes all posts<br>

<br><input type=checkbox id="resetFolderDefault" name="resetFolderDefault"><b> Reset</b> - Reset to folder default setting<br>
<% addHandler("resetFolderDefault", "click", "toggleOption();"); %>
<br><input type=checkbox id="resetFolderDefault" name="resetFolderDefault"><b> Reset</b> - Reset to folder default setting<br>
<% addHandler("resetFolderDefault", "click", "toggleOptions();"); %>

<br><%=generateReturnUrlFormField(returnUrl)%>
<br><input type=hidden name="srcIdentifier" value="<%=h(srcIdentifier)%>"/>
Expand Down