Skip to content

Tighten birth and conception entry and drop legacy nbri_ehr tables - #20

Open
labkey-martyp wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_ehr_birth_conception_cleanup
Open

Tighten birth and conception entry and drop legacy nbri_ehr tables#20
labkey-martyp wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_ehr_birth_conception_cleanup

Conversation

@labkey-martyp

Copy link
Copy Markdown
Contributor

Rationale

Tighten what the birth and conception forms accept, and retire the tables the nbri_ehr schema inherited from the legacy system. The form changes come out of the bulk data entry work: conception term date was never populated, and the birth fields that the Start with Conception window fills could still be edited by hand, which let a birth drift out of sync with the conception it came from. Nothing in the module reads the legacy tables, so they only add noise to the schema browser, the lookup administration page and every future upgrade script.

Related Pull Requests

None.

Changes

  • Remove conception term date, and make conception date required.
  • Remove birth condition from the birth form and the birth dataset.
  • Make the birth fields that the Start with Conception window populates read-only, so they cannot be edited away from the conception record they came from.
  • Drop the legacy tables from the nbri_ehr schema along with the queries, custom views, lookups and referencing columns that existed only to serve them. Conception is the only table left in the schema.
  • Stop reloading flag values from the production lookups manifest, so values configured at a site are no longer overwritten.

Conception is the only table left in the nbri_ehr schema — the rest were carried over from the legacy system and nothing reads them, so their queries, lookups and referencing columns go too. On the entry side, birth condition and conception term date are gone, conception date is now required, and the fields the Start with Conception window populates are read-only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant