Issue 1364: Better handling for error handling and canceled requests - #2059
Open
labkey-susanh wants to merge 6 commits into
Open
Issue 1364: Better handling for error handling and canceled requests#2059labkey-susanh wants to merge 6 commits into
labkey-susanh wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1364: It can occasionally happen that a page element that relies on a query model will show a Loading spinner indefinitely. This most likely happens when there is an error response that looks like a canceled request, so the error is never handled and the loading state is never updated.
Related Pull Requests
Changes
RequestTracker, wrapping aRequestHandlerto explicitly track cancelations