Sample color display - grid column renderer, sample detail header, storage box view, etc. - #2056
Open
cnathe wants to merge 45 commits into
Open
Sample color display - grid column renderer, sample detail header, storage box view, etc.#2056cnathe wants to merge 45 commits into
cnathe wants to merge 45 commits into
Conversation
…E_COLOR_REQUIRED_COLUMNS in requiredColumns
…when no colors defined in project
…n header" for sample type with sample color breakdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Surface the sample color assigned via project-level sample colors throughout the sample UI — grid columns, detail views, lineage details, editable grids, and storage capacity breakdowns — and only include the color column where the project actually has active colors defined. Also removes the experimental feature flag now that the feature is complete.
Related Pull Requests
Changes
ExpMaterialColorand useSAMPLE_COLOR_REQUIRED_COLUMNSforrequiredColumns; addedQueryInfo.showSampleColorColand exportedSAMPLE_COLOR_COLOR_COLUMN_NAME.Apphelpers to readhasActiveProjectColorsfrommoduleContext, used to gate color display:getOmittedSampleTypeColumnsaddsSAMPLE_COLOR_REQUIRED_COLUMNSwhen no colors are defined in the project, and sample type system fields includeExpMaterialColoronly when colors are active.SampleColorRenderer: addedcls,showLabel, anduseSmallprops plus styling updates;SampleColorInputoption renderer now includesColorIcon.HorizontalBarSectionandItemsLegendhandle a section header for the sample type with sample color breakdown.QueryModel.flattenValuesFromRownow carriesdisplayValue.