replace all references to project_name parameter with container_path #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example data referenced in comment does not exist
replace project_name references with container_path
replace project_name references with container_path
replace project_name reference with container_path
replace project_name reference with container_path
replace project_name with container_path
replace project_name with container_path
replace project_name with container_path
jryurkanin
changed the title
replace references to projects with container path
cnathe
approved these changes
Apr 15, 2024
README.md
Outdated
| # Note: If developing against localhost with https disabled, set use_ssl=False below | ||
| api = APIWrapper(labkey_server, container_path, contextPath) | ||
|
|
||
| # Makes an API request to https://www.example.com/labkey/ModuleAssayTest/query-getQuery.api |
There was a problem hiding this comment.
do you want to replace the ModuleAssayTest in the example URL here as well to match the container_path at line 96?
There was a problem hiding this comment.
Yeah we should definitely fix that, otherwise it will be rather confusing
There was a problem hiding this comment.
good catch, thanks guys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
replacing project_name with container_path for clarity.
Related Pull Requests
Changes