Skip to content

checkpoint POC for smaller GetQueryDetails.api response #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions src/labkey/query/GetQueryDetails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export interface QueryDetailsResponse {
name: string;
schemaName: string;
targetContainers: Container[];
templateColumn : QueryColumn;
title: string;
titleColumn: string;
viewDataUrl: string;
Expand Down Expand Up @@ -171,10 +172,51 @@ export function getQueryDetails(options: GetQueryDetailsOptions): XMLHttpRequest
params.includeTriggers = options.includeTriggers;
}


function _expandColumnMetaData(template : any, col : any)
{
const name = col.name;
for (let key in ['fieldKey', 'fieldKeyPath', 'shortCaption', 'caption']) {
if (!(key in col))
col[key] = name;
}
if (!('fieldKeyArray' in col))
col['fieldKeyArray'] = [name];
return Object.assign(Object.assign({}, template), col);
}

function _transformQueryDetailsResponse(json : any) : any
{
const template = json.templateColumn;
// if null==template we don't do any compression, including name/fieldKey/caption etc
if (!template)
return json;
if (Array.isArray(json.columns)) {
let columns = json.columns;
for (let i in columns)
columns[i] = _expandColumnMetaData(template, columns[i]);
}
if (json.defaultView && Array.isArray(json.defaultView.columns)) {
let columns = json.defaultView.columns;
for (let i in columns)
columns[i] = _expandColumnMetaData(template, columns[i]);
}
if (Array.isArray(json.views)) {
for (let v in json.views) {
if (Array.isArray(json.views[v].fields)) {
let columns = json.views[v].fields;
for (let i in columns)
columns[i] = _expandColumnMetaData(template, columns[i]);
}
}
}
return json;
}

return request({
url: buildURL('query', 'getQueryDetails.api', options.containerPath),
url: buildURL('query', 'getQueryDetails2.api', options.containerPath),
method: getMethod(options.method),
success: getCallbackWrapper(getOnSuccess(options), options.scope),
success: getCallbackWrapper(getOnSuccess(options), options.scope, false, _transformQueryDetailsResponse),
failure: getCallbackWrapper(getOnFailure(options), options.scope, true),
params,
});
Expand Down