Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local_tw_csv script #292

Merged
merged 12 commits into from
Aug 8, 2024
Merged

Remove local_tw_csv script #292

merged 12 commits into from
Aug 8, 2024

Conversation

siuwuncheung
Copy link
Member

@siuwuncheung siuwuncheung commented Jun 27, 2024

### (Requires the attention of all folks working on DMD.)
This PR removes the local_tw_csv.cpp, as its functionality is included in parametric_tw_csv.cpp.

There are some additional changes in parametric_tw_csv.cpp:

  • for the fixed time step case, the DMD default option is reset.
  • fix a segmentation fault when there are multiple testing parameters (thanks @ptranq for catching it)
  • the command lines and results are verified and added to the header.
  • the instruction of the MFEM heat conduction database generation is made a little clearer.
  • add regression tests for the capabilities

Copy link
Collaborator

@chldkdtn chldkdtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Can you also make similar change in pylibROM as well?

Plus, can you also add regression tests on parametric_tw_csv to test local_tw feature?

@siuwuncheung siuwuncheung merged commit 1133af0 into master Aug 8, 2024
4 checks passed
@dylan-copeland dylan-copeland deleted the tw_csv_dmd_cleanup branch August 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants