Add Sina as Axom component #1378
Conversation
…re/bgunnar5/sina-integration
…gunnar5/sina-integration
|
I'm having issue linking one of our codes against this (segfault). I might be in the code itself, it might be in this new library. Can we hold off merging this until this linking issue is solved. Also if any of you could try to link your favorite code against this and run a few sina-enabled examples that would be great. Thx! |
Solved I had to add this flag: |
Co-authored-by: Kenny Weiss <[email protected]>
… feature/bgunnar5/sina-integration
Note: We discussed this offline, and the problem was related to a missing for |
|
So I built and deplyeoyed. But I don't think the mod file for fortran is installed: (base) [cdoutrix@rzwhippet17:build]$ find /usr/workspace/cdoutrix/axom_build/install -name "*mod"
(base) [cdoutrix@rzwhippet17:build]$ find /usr/workspace/cdoutrix/axom_build/build -name "*mod"
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/mymodule.mod
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/my_module.mod
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/VerifyC/CMakeFiles/FortranCInterface/mymodule.mod
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/VerifyC/CMakeFiles/FortranCInterface/my_module.mod
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/VerifyCXX/CMakeFiles/FortranCInterface/mymodule.mod
/usr/workspace/cdoutrix/axom_build/build/CMakeFiles/FortranCInterface/VerifyCXX/CMakeFiles/FortranCInterface/my_module.mod
/usr/workspace/cdoutrix/axom_build/build/lib/fortran/fruit.mod
/usr/workspace/cdoutrix/axom_build/build/lib/fortran/fruit_util.mod
/usr/workspace/cdoutrix/axom_build/build/lib/fortran/fruit_smoke.mod
/usr/workspace/cdoutrix/axom_build/build/lib/fortran/f_conduit_smoke.mod
/usr/workspace/cdoutrix/axom_build/build/lib/fortran/sina_functions.modmake test shows the fortran test passing so I think that part is ok |
…gunnar5/sina-integration
…gunnar5/sina-integration
|
|
||
| int main(void) | ||
| { | ||
| // Initialize slic | ||
| axom::slic::initialize(); |
There was a problem hiding this comment.
Minor:
slic::SimpleLogger is an RAII wrapper around slic::initialize and slic::finalize that can be used for simple examples like this,
See:
https://github.com/LLNL/axom/blob/develop/src/axom/slic/core/SimpleLogger.hpp
(No need to change these examples, just wanted to let you know about it in case you didn't)
There was a problem hiding this comment.
I wasn't aware of this so thanks for the heads up! :)
|
@LLNL/axom I think this is finally ready to hit the merge button |
Summary
This PR is kind of a mirror PR for #1376 (Sina as an Axom component) that allows Axom's CI tests to run. The procedure for forked repo contributions was followed.
Note that this PR must be approved as it will be merged.
Also note that I activated the generated docs for Sina on RTD so they can be reviewed for formatting, etc. Here is the link: https://axom.readthedocs.io/en/pr-from-fork-1376/axom/sina/docs/sphinx/index.html