Timestep Velocity Projection Modification #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… computing an delta interpen.
ebchin
requested changes
Jan 24, 2025
src/tribol/mesh/CouplingScheme.cpp
Outdated
| proj_delta_x1 -= proj_delta_x2; | ||
| proj_delta_y1 -= proj_delta_y2; | ||
|
|
||
| proj_delta_x2 -= proj_delta_x1; |
There was a problem hiding this comment.
Is this right? I think we want to -= proj_delta_x1 before modifying it on the above lines (L1528)? Same with y and z below.
There was a problem hiding this comment.
Good catch. I think I fixed this by using the original proj_delta_x1 based on the velocity projection of that point, not the modified one as is done here (modified on L1528 and used on L1531).
…alues in computing delta between projected cp centroid
ebchin
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current velocity projection check performs a velocity projection of the overlap centroid as projected to one face in a face-pair and compares this against the face-projected overlap centroid on the OTHER face in the CURRENT configuration. If both faces are moving toward one another, this underestimates the amount of interpenetration.
This PR introduces the change where the velocity projection of the overlap centroid as projected to one face is compared against the velocity projected overlap centroid (on the other face), which represents a PROJECTED configuration rather than the current configuration. This will more accurately catch excessive interpenetration for nonzero incoming velocities and trigger a contact timestep vote.