Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustifies the RT60 computation function #347

Merged
merged 3 commits into from
May 23, 2024
Merged

robustifies the RT60 computation function #347

merged 3 commits into from
May 23, 2024

Conversation

fakufaku
Copy link
Collaborator

This modification adds a new parameter to the measure_rt60 routine that allows to discard long noisy tails in measured RIR.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR 😃

@fakufaku fakufaku merged commit 2d00433 into master May 23, 2024
38 checks passed
@fakufaku fakufaku deleted the dev/measure_t60 branch May 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant