merge master

CHANGELOG.rst

@@ -11,24 +11,9 @@ adheres to `Semantic Versioning <http://semver.org/spec/v2.0.0.html>`_.
 `Unreleased`_
 -------------
 
-Nothing yet
-
-`0.7.4`_ - 2024-04-25
----------------------
-
 Added
 ~~~~~
 
-- Simulation with measured directivity responses in SOFA format (limited file types) is
-  possible with the image source model.
-- New implementation of fast RIR builder function in the ``libroom`` C++
-  extension to replace the current cython code. Advantages are: 1) only one
-  compiled extension, 2) multithreading support
-- New global parameter ``sinc_lut_granularity`` that controls the number of points used
-  in the look-up table for the sinc interpolation. Accessible via ``parameters.constants.get``.
-- New global parameter  ``num_threads`` that controls the number of threads used in
-  multi-threaded code (rir builder only at the moment). The number of threads can also
-  be controlled via the environement variable ``PRA_NUM_THREADS``
 - New global parameters to control the octave bands used for simulation.
   * ``octave_bands_base_freq``: the base frequency used for the octave bands (default ``125 ``),
     note that together with the sampling frequency this will determine the number of sub-bands
@@ -42,10 +27,36 @@ Added
 Changed
 ~~~~~~~
 
-- Removed the broken ``get_rir`` method of the class ``SoundSource``
 - In ray tracing, the histograms are now linearly interpolated between
   the bins to obtain smoother RIR
 
+`0.7.4`_ - 2024-04-25
+---------------------
+
+Added
+~~~~~
+
+- Simulation with measured directivity responses in SOFA format (limited file types) is
+  possible with the image source model.
+- New implementation of fast RIR builder function in the ``libroom`` C++
+  extension to replace the current cython code. Advantages are: 1) only one
+  compiled extension, 2) multithreading support
+- New global parameter ``sinc_lut_granularity`` that controls the number of
+  points used in the look-up table for the sinc interpolation. Accessible via
+  ``parameters.constants.get``.
+- New global parameter  ``num_threads`` that controls the number of threads
+  used in multi-threaded code (rir builder only at the moment). The number of
+  threads can also be controlled via the environement variable
+  ``PRA_NUM_THREADS``
+- Adds package build support for Python 3.11 and 3.12. - Adds package build for
+  new Apple M1 architecture
+
+Changed
+~~~~~~~
+
+- Removed the broken ``get_rir`` method of the class ``SoundSource``
+- Removes package build support for Python 3.7 (EOL)
+
 Bugfix
 ~~~~~~
 

pyroomacoustics/libroom_src/rir_builder.cpp

@@ -44,8 +44,8 @@ constexpr T get_pi() {
 template <class T>
 void threaded_rir_builder_impl(
     py::array_t<T, py::array::c_style | py::array::forcecast> rir,
-    const py::array_t<T, py::array::c_style | py::array::forcecast> time,
-    const py::array_t<T, py::array::c_style | py::array::forcecast> alpha,
+    const py::array_t<T, py::array::c_style | py::array::forcecast> &time,
+    const py::array_t<T, py::array::c_style | py::array::forcecast> &alpha,
     int fs, size_t fdl, size_t lut_gran, size_t num_threads) {
 
   auto pi = get_pi<T>();
@@ -162,7 +162,7 @@ void threaded_rir_builder_impl(
   for (auto &&result : sum_results) result.get();
 }
 
-void rir_builder(py::buffer rir, const py::buffer time, const py::buffer alpha,
+void rir_builder(py::buffer rir, const py::buffer &time, const py::buffer &alpha,
                  int fs, size_t fdl, size_t lut_gran, size_t num_threads) {
   // dispatch to correct implementation depending on input type
   auto buf = pybind11::array::ensure(rir);

pyroomacoustics/libroom_src/rir_builder.hpp

@@ -7,7 +7,7 @@
 
 namespace py = pybind11;
 
-void rir_builder(py::buffer rir, const py::buffer time, const py::buffer alpha,
+void rir_builder(py::buffer rir, const py::buffer &time, const py::buffer &alpha,
                  int fs, size_t fdl, size_t lut_gran, size_t num_threads);
 
 void delay_sum(const py::buffer irs, const py::buffer delays, py::buffer output,