Add AOC Container Base into AOC Refactor#244
Open
cooperj wants to merge 8 commits intoaoc_refactorfrom
Open
Conversation
…navigation into aoc_refactor_container
Member
Author
|
Looking into removing the requirement for What I'm looking for is people to play with it and let me know what they think regarding the usability of it, and then build a deployable version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new
AOC Container Basedocker workflow, as a part of #242.You should be able to test this either using the devcontainer configuration for development workflows or running the
demo.compose.yamlfile with the commands:I have built this on the
stagingrelease of aoc_container_base while we are working on the VNC workflow (LCAS/aoc_container_base#2) to be finalised.After that I think we should look at is the production/on-robot deployment of this, including adding extra steps such as github workflows.
**Copilot Summary**
This pull request refactors the development container setup for the project, moving from a single Dockerfile-based approach to a more modular, Docker Compose-based workflow. The changes introduce a multi-stage Dockerfile, new Docker Compose configurations for both development and demo environments, and clean up redundant scripts. The setup now uses a dedicated
rosuser, persistent build volumes, and an integrated VNC service for GUI access.Development container and workflow modernization:
.devcontainer/compose.yamlfor development anddemo.compose.yamlfor demo deployments, each orchestrating both the main ROS container and a VNC service for GUI access. (.devcontainer/compose.yaml,demo.compose.yaml) [1] [2].devcontainer/devcontainer.jsonto use the new Compose setup, specify therosuser, and forward the correct VNC port. (.devcontainer/devcontainer.json)Dockerfile improvements and user management:
.devcontainer/Dockerfileto support multi-stage builds, use a custom base image, set up the workspace for therosuser, and automate dependency installation and building withcolcon. (.devcontainer/Dockerfile)Cleanup of legacy scripts:
install.sh,run.sh) that are no longer needed with the new automated Dockerfile and Compose setup. (.devcontainer/install.sh,.devcontainer/run.sh) [1] [2]