-
Notifications
You must be signed in to change notification settings - Fork 0
Add Cyclone DDS as default supported DDS scheme #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
433fa9a
feat: add cyclone dds support
cooperj 73c5495
fix: correct path
cooperj 66e284e
fix: update path to match context
cooperj c266682
fix: isolate cyclonedds steps
cooperj a08160b
ci: maybe apt clean will fix this?
cooperj 2cd9a89
fix: update bashrc to work better
cooperj 6c3b7ed
ci: fake commit to trigger build
cooperj ebc991f
chore: mv cyclone install to same block
cooperj 06e09a5
fix: dont clean first!
cooperj 7985f60
ci: disable cache and dont apt clean
cooperj 178364b
fix: update package installation to include locale settings
cooperj 4d94d35
ci: fix this time i hope
cooperj 53690bb
ci: come on, disable cache
cooperj c47814c
fix: update locale settings to use en_US.UTF-8
cooperj 1b7b052
ci: add docker pull step
cooperj e86b3a7
ci: change tags to a newer cuda tag
cooperj a814a5e
ci: debugging
cooperj 0b2f00a
ci: clean up and try again
cooperj e3e0429
fix: run as sudo for updates in desktop
cooperj de5636e
fix: rm as sudo
cooperj 001de9c
ci: undo changes from when the runners broke
cooperj 30d3e7b
Apply suggestions from code review
cooperj 730adf8
fix: move the env for RMW and Cyclone into actual ENVs
cooperj c761948
Apply suggestions from code review
cooperj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| ARG BASE_IMAGE | ||
| ARG BASE_IMAGE=lcas.lincoln.ac.uk/ros_cuda:humble-main | ||
|
|
||
| ########################################### | ||
| FROM ${BASE_IMAGE} AS base | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| RUN sudo apt-get update && sudo apt-get install -y --no-install-recommends \ | ||
| ros-${ROS_DISTRO}-desktop \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| && sudo rm -rf /var/lib/apt/lists/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <CycloneDDS> | ||
| <Domain> | ||
| <General> | ||
| <AllowMulticast>true</AllowMulticast> | ||
| </General> | ||
| <Discovery> | ||
| <ParticipantIndex>auto</ParticipantIndex> | ||
| </Discovery> | ||
| </Domain> | ||
| </CycloneDDS> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.