Rewrite digest middleware #990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudokoko
approved these changes
Mar 1, 2024
Member
sudokoko
left a comment
sudokoko
left a comment
There was a problem hiding this comment.
one minor comment but otherwise this is fine
Member
|
merge conflicts and @Zaprit review bump |
# Conflicts: # ProjectLighthouse.Servers.GameServer/Controllers/Slots/ReviewController.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of the digest middleware. The new version makes it much less dependent on hardcoded endpoints and the digests in the config. Now the hardcoded behavior can be controlled by changing properties in the
UseDigestAttributeclass, like whether or not the request should fail if the client sends an incorrect digest or what the digest header name should be. The middleware can now also use unlimited digest keys to check against.This PR also adds a new GameController class which extracts most of the common attributes the LBP endpoints use so they don't have to be redefined in every file.