Skip to content

Commit 85bd071

Browse files
authored
Merge pull request #32 from irgaly/v1.1.0_fix_jitpack
fix: Jitpack, CircleCI releases
2 parents f232865 + b2d309a commit 85bd071

20 files changed

+74
-59
lines changed

.circleci/config.yml

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
version: 2
1+
version: 2.1
22
jobs:
33
build:
44
docker:
5-
- image: circleci/android:api-26-alpha
5+
- image: circleci/android:api-30
66

77
working_directory: ~/repo
88

@@ -29,14 +29,6 @@ jobs:
2929
name: Run Tests
3030
command: ./gradlew testDebug
3131

32-
- run:
33-
name: Check
34-
command: |
35-
if [ ! $CIRCLE_BRANCH = 'master' ]; then
36-
./gradlew --stacktrace lintDebug
37-
./gradlew --stacktrace ktlintDebugCheck
38-
fi
39-
4032
- store_artifacts:
4133
path: app/build/outputs
4234
destination: outputs

build.gradle

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ import dependencies.Depends
33
buildscript {
44
repositories {
55
google()
6-
jcenter()
76
mavenCentral()
8-
maven { url "https://plugins.gradle.org/m2/" }
7+
gradlePluginPortal()
98
maven { url "https://jitpack.io" }
109
}
1110
dependencies {
@@ -17,7 +16,7 @@ buildscript {
1716
allprojects {
1817
repositories {
1918
google()
20-
jcenter()
19+
mavenCentral()
2120
maven { url "https://jitpack.io" }
2221
}
2322
}

buildSrc/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ plugins {
22
`kotlin-dsl`
33
}
44
repositories {
5-
jcenter()
6-
}
5+
mavenCentral()
6+
}

buildSrc/src/main/java/dependencies/Depends.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ object Depends {
88
}
99

1010
object Test {
11-
const val junit = "junit:junit:4.12"
12-
const val testRunner = "androidx.test:runner:1.1.0"
11+
const val junit = "junit:junit:4.13.2"
12+
const val testRunner = "androidx.test:runner:1.4.0"
1313
const val mockitoKotlin = "com.nhaarman.mockitokotlin2:mockito-kotlin:2.0.0"
14-
const val robolectric = "org.robolectric:robolectric:3.5.1"
14+
const val robolectric = "org.robolectric:robolectric:4.6.1"
1515

1616
object Espresso {
1717
const val core = "androidx.test.espresso:espresso-core:3.1.0-alpha4"

example/build.gradle

+1-12
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,6 @@ android {
2121
versionCode versionMajor * 10000 + versionMinor * 100 + versionPatch
2222
versionName "$versionMajor.$versionMinor.$versionPatch"
2323
}
24-
signingConfigs {
25-
release {
26-
storeFile file("debug.keystore")
27-
storePassword "android"
28-
keyAlias "androiddebugkey"
29-
keyPassword "android"
30-
}
31-
}
32-
dexOptions {
33-
preDexLibraries false
34-
}
3524
buildTypes {
3625
debug {
3726
applicationIdSuffix '.debug'
@@ -42,7 +31,7 @@ android {
4231
zipAlignEnabled true
4332
minifyEnabled false
4433
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
45-
signingConfig signingConfigs.release
34+
signingConfig signingConfigs.debug
4635
}
4736
}
4837
testOptions {

example/src/test/java/co/kyash/vtl/example/testing/RxImmediateSchedulerRule.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package co.kyash.vtl.example.testing
22

3-
import io.reactivex.plugins.RxJavaPlugins
4-
import io.reactivex.schedulers.Schedulers
3+
import io.reactivex.rxjava3.plugins.RxJavaPlugins
4+
import io.reactivex.rxjava3.schedulers.Schedulers
55
import org.junit.rules.TestRule
66
import org.junit.runner.Description
77
import org.junit.runners.model.Statement
@@ -26,4 +26,4 @@ class RxImmediateSchedulerRule : TestRule {
2626
}
2727
}
2828

29-
}
29+
}

example/src/test/java/co/kyash/vtl/example/validators/MaterialDesignColorsValidatorTest.kt

+5-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import co.kyash.vtl.example.testing.RxImmediateSchedulerRule
66
import co.kyash.vtl.validators.VtlValidator
77
import com.nhaarman.mockitokotlin2.doReturn
88
import com.nhaarman.mockitokotlin2.mock
9-
import io.reactivex.Single
9+
import io.reactivex.rxjava3.core.Single
1010
import org.junit.Before
1111
import org.junit.Ignore
1212
import org.junit.Rule
@@ -67,8 +67,10 @@ class MaterialDesignColorsValidatorTest(
6767
if (errorMessage == null) {
6868
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6969
} else {
70-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
70+
subject.validateAsCompletable(context, text).test().assertError {
71+
it.message == errorMessage
72+
}
7173
}
7274
}
7375

74-
}
76+
}

gradle.properties

-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
11
org.gradle.jvmargs=-Xmx1536m
2-
android.databinding.enableV2=true
32
android.useAndroidX=true
4-
android.enableJetifier=true

jitpack.yml

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
jdk:
2+
- openjdk11

library/build.gradle

+16-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import dependencies.Versions
33

44
apply plugin: 'com.android.library'
55
apply plugin: 'kotlin-android'
6+
apply plugin: 'maven-publish'
67

78
def versionMajor = 1
89
def versionMinor = 1
@@ -30,6 +31,21 @@ android {
3031
}
3132
}
3233

34+
testOptions {
35+
unitTests.includeAndroidResources = true
36+
}
37+
}
38+
39+
afterEvaluate {
40+
publishing {
41+
publications {
42+
release(MavenPublication) {
43+
from components.release
44+
artifactId = "validatable-textinput-layout"
45+
artifact(sourcesJar)
46+
}
47+
}
48+
}
3349
}
3450

3551
dependencies {
@@ -46,7 +62,6 @@ dependencies {
4662
testImplementation Depends.Test.robolectric
4763
}
4864

49-
// build a jar with source files
5065
task sourcesJar(type: Jar) {
5166
from android.sourceSets.main.java.srcDirs
5267
classifier = 'sources'

library/src/test/java/co/kyash/vtl/testing/RxImmediateSchedulerRule.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package co.kyash.vtl.testing
22

3-
import io.reactivex.plugins.RxJavaPlugins
4-
import io.reactivex.schedulers.Schedulers
3+
import io.reactivex.rxjava3.plugins.RxJavaPlugins
4+
import io.reactivex.rxjava3.schedulers.Schedulers
55
import org.junit.rules.TestRule
66
import org.junit.runner.Description
77
import org.junit.runners.model.Statement
@@ -26,4 +26,4 @@ class RxImmediateSchedulerRule : TestRule {
2626
}
2727
}
2828

29-
}
29+
}

library/src/test/java/co/kyash/vtl/validators/AlphabetOnlyValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@ class AlphabetOnlyValidatorTest(
6868
if (errorMessage == null) {
6969
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
7070
} else {
71-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
71+
subject.validateAsCompletable(context, text).test().assertError { it ->
72+
it.message == errorMessage
73+
}
7274
}
7375
}
7476

75-
}
77+
}

library/src/test/java/co/kyash/vtl/validators/AsciiOnlyValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,10 @@ class AsciiOnlyValidatorTest(
6565
if (errorMessage == null) {
6666
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6767
} else {
68-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
68+
subject.validateAsCompletable(context, text).test().assertError { it ->
69+
it.message == errorMessage
70+
}
6971
}
7072
}
7173

72-
}
74+
}

library/src/test/java/co/kyash/vtl/validators/EmailValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ class EmailValidatorTest(
6161
if (errorMessage == null) {
6262
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6363
} else {
64-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
64+
subject.validateAsCompletable(context, text).test().assertError { it ->
65+
it.message == errorMessage
66+
}
6567
}
6668
}
6769

68-
}
70+
}

library/src/test/java/co/kyash/vtl/validators/HiraganaOnlyValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ class HiraganaOnlyValidatorTest(
6262
if (errorMessage == null) {
6363
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6464
} else {
65-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
65+
subject.validateAsCompletable(context, text).test().assertError { it ->
66+
it.message == errorMessage
67+
}
6668
}
6769
}
6870

69-
}
71+
}

library/src/test/java/co/kyash/vtl/validators/KatakanaOnlyValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ class KatakanaOnlyValidatorTest(
6262
if (errorMessage == null) {
6363
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6464
} else {
65-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
65+
subject.validateAsCompletable(context, text).test().assertError { it ->
66+
it.message == errorMessage
67+
}
6668
}
6769
}
6870

69-
}
71+
}

library/src/test/java/co/kyash/vtl/validators/MinLengthValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,10 @@ class MinLengthValidatorTest(
6464
if (errorMessage == null) {
6565
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6666
} else {
67-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
67+
subject.validateAsCompletable(context, text).test().assertError { it ->
68+
it.message == errorMessage
69+
}
6870
}
6971
}
7072

71-
}
73+
}

library/src/test/java/co/kyash/vtl/validators/NoSpecialCharacterValidatorTest.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ class NoSpecialCharacterValidatorTest(
7171
if (errorMessage == null) {
7272
validator.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
7373
} else {
74-
validator.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
74+
validator.validateAsCompletable(context, text).test().assertError { it ->
75+
it.message == errorMessage
76+
}
7577
}
7678
}
7779
}

library/src/test/java/co/kyash/vtl/validators/NumberOnlyValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ class NumberOnlyValidatorTest(
5959
if (errorMessage == null) {
6060
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6161
} else {
62-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
62+
subject.validateAsCompletable(context, text).test().assertError { it ->
63+
it.message == errorMessage
64+
}
6365
}
6466
}
6567

66-
}
68+
}

library/src/test/java/co/kyash/vtl/validators/RequiredValidatorTest.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,10 @@ class RequiredValidatorTest(
6363
if (errorMessage == null) {
6464
subject.validateAsCompletable(context, text).test().assertNoErrors().assertComplete()
6565
} else {
66-
subject.validateAsCompletable(context, text).test().assertErrorMessage(errorMessage)
66+
subject.validateAsCompletable(context, text).test().assertError { it ->
67+
it.message == errorMessage
68+
}
6769
}
6870
}
6971

70-
}
72+
}

0 commit comments

Comments
 (0)