Skip to content

Commit f232865

Browse files
authored
Merge pull request #31 from irgaly/v1.1.0_rxjava3
Support RxJava3
2 parents f1a41ad + e098dfe commit f232865

25 files changed

+163
-172
lines changed

build.gradle

-4
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,11 @@ buildscript {
66
jcenter()
77
mavenCentral()
88
maven { url "https://plugins.gradle.org/m2/" }
9-
maven { url 'https://maven.fabric.io/public' }
109
maven { url "https://jitpack.io" }
1110
}
1211
dependencies {
1312
classpath Depends.GradlePlugin.android
1413
classpath Depends.GradlePlugin.kotlin
15-
classpath Depends.GradlePlugin.ktlint
16-
classpath Depends.GradlePlugin.fabric
17-
classpath Depends.GradlePlugin.androidMaven
1814
}
1915
}
2016

buildSrc/src/main/java/dependencies/Depends.kt

+8-12
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,8 @@ package dependencies
33
@Suppress("unused")
44
object Depends {
55
object GradlePlugin {
6-
const val android = "com.android.tools.build:gradle:3.2.1"
6+
const val android = "com.android.tools.build:gradle:7.0.0"
77
const val kotlin = "org.jetbrains.kotlin:kotlin-gradle-plugin:${Kotlin.version}"
8-
const val ktlint = "gradle.plugin.org.jlleitschuh.gradle:ktlint-gradle:3.0.0"
9-
const val fabric = "io.fabric.tools:gradle:1.25.4"
10-
const val androidMaven = "com.github.dcendents:android-maven-gradle-plugin:2.0"
118
}
129

1310
object Test {
@@ -30,8 +27,7 @@ object Depends {
3027
}
3128

3229
object Kotlin {
33-
const val version = "1.3.11"
34-
const val stdlib = "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$version"
30+
const val version = "1.5.21"
3531
}
3632

3733
object Stetho {
@@ -45,10 +41,10 @@ object Depends {
4541
}
4642

4743
object Retrofit {
48-
private const val version = "2.5.0"
44+
private const val version = "2.9.0"
4945
const val core = "com.squareup.retrofit2:retrofit:$version"
5046
const val converterMoshi = "com.squareup.retrofit2:converter-moshi:$version"
51-
const val adapterRxJava2 = "com.squareup.retrofit2:adapter-rxjava2:$version"
47+
const val adapterRxJava3 = "com.squareup.retrofit2:adapter-rxjava3:$version"
5248
}
5349

5450
object Kotshi {
@@ -58,8 +54,8 @@ object Depends {
5854
}
5955

6056
object Rx {
61-
const val RxJava = "io.reactivex.rxjava2:rxjava:2.2.4"
62-
const val RxAndroid = "io.reactivex.rxjava2:rxandroid:2.1.0"
63-
const val RxKotlin = "io.reactivex.rxjava2:rxkotlin:2.3.0"
57+
const val RxJava = "io.reactivex.rxjava3:rxjava:3.0.13"
58+
const val RxAndroid = "io.reactivex.rxjava3:rxandroid:3.0.0"
59+
const val RxKotlin = "io.reactivex.rxjava3:rxkotlin:3.0.1"
6460
}
65-
}
61+
}
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package dependencies
22

33
private object Versions {
4-
val androidCompileSdkVersion = 28
5-
val androidTargetSdkVersion = 28
4+
val androidCompileSdkVersion = 30
5+
val androidTargetSdkVersion = 30
66
val androidMinSdkVersion = 19
7-
}
7+
}

example/build.gradle

+1-14
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import dependencies.Versions
44
apply plugin: 'com.android.application'
55
apply plugin: 'kotlin-android'
66
apply plugin: 'kotlin-kapt'
7-
apply plugin: "org.jlleitschuh.gradle.ktlint"
8-
apply plugin: 'io.fabric'
97
apply from: "${rootDir.absolutePath}/versions.gradle"
108

119
def versionMajor = 1
@@ -22,7 +20,6 @@ android {
2220
targetSdkVersion Versions.androidTargetSdkVersion
2321
versionCode versionMajor * 10000 + versionMinor * 100 + versionPatch
2422
versionName "$versionMajor.$versionMinor.$versionPatch"
25-
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
2623
}
2724
signingConfigs {
2825
release {
@@ -61,9 +58,6 @@ android {
6158
dependencies {
6259
implementation project(':library')
6360

64-
//==================== Kotlin ====================
65-
implementation Depends.Kotlin.stdlib
66-
6761
//==================== Support Library ====================
6862
implementation Depends.AndroidX.appCompat
6963
implementation Depends.AndroidX.design
@@ -72,7 +66,7 @@ dependencies {
7266
//==================== Network ====================
7367
implementation Depends.Retrofit.core
7468
implementation Depends.Retrofit.converterMoshi
75-
implementation Depends.Retrofit.adapterRxJava2
69+
implementation Depends.Retrofit.adapterRxJava3
7670

7771
//==================== Structure ====================
7872
implementation Depends.Kotshi.api
@@ -99,10 +93,3 @@ dependencies {
9993
androidTestImplementation Depends.Test.Espresso.core
10094
androidTestImplementation Depends.Test.Espresso.intents
10195
}
102-
103-
ktlint {
104-
version = versions.ktlint
105-
android = true
106-
reporter = "checkstyle"
107-
ignoreFailures = true
108-
}

example/src/main/AndroidManifest.xml

+1-5
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
android:supportsRtl="true"
1616
android:theme="@style/AppTheme">
1717

18-
<meta-data
19-
android:name="io.fabric.ApiKey"
20-
android:value="0a7aa1279a42a1b8dd1e111287030f783b9ee2d2" />
21-
2218
<activity android:name="co.kyash.vtl.example.MainActivity">
2319
<intent-filter>
2420
<action android:name="android.intent.action.MAIN" />
@@ -28,4 +24,4 @@
2824
</activity>
2925
</application>
3026

31-
</manifest>
27+
</manifest>

example/src/main/java/co/kyash/vtl/example/MainActivity.kt

+7-9
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@ import co.kyash.vtl.validators.RequiredValidator
1717
import com.crashlytics.android.Crashlytics
1818
import com.facebook.stetho.okhttp3.StethoInterceptor
1919
import com.squareup.moshi.Moshi
20-
import io.fabric.sdk.android.Fabric
21-
import io.reactivex.Completable
22-
import io.reactivex.Flowable
23-
import io.reactivex.android.schedulers.AndroidSchedulers
24-
import io.reactivex.disposables.CompositeDisposable
25-
import io.reactivex.schedulers.Schedulers
20+
import io.reactivex.rxjava3.android.schedulers.AndroidSchedulers
21+
import io.reactivex.rxjava3.core.Completable
22+
import io.reactivex.rxjava3.core.Flowable
23+
import io.reactivex.rxjava3.disposables.CompositeDisposable
24+
import io.reactivex.rxjava3.schedulers.Schedulers
2625
import okhttp3.OkHttpClient
2726
import retrofit2.Retrofit
28-
import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory
27+
import retrofit2.adapter.rxjava3.RxJava3CallAdapterFactory
2928
import retrofit2.converter.moshi.MoshiConverterFactory
3029

3130

@@ -44,14 +43,13 @@ class MainActivity : AppCompatActivity() {
4443
private val api = Retrofit.Builder()
4544
.baseUrl("https://raw.githubusercontent.com")
4645
.addConverterFactory(MoshiConverterFactory.create(Moshi.Builder().build()))
47-
.addCallAdapterFactory(RxJava2CallAdapterFactory.createAsync())
46+
.addCallAdapterFactory(RxJava3CallAdapterFactory.create())
4847
.client(OkHttpClient.Builder().addNetworkInterceptor(StethoInterceptor()).build())
4948
.build()
5049
.create(MaterialDesignColorsApi::class.java)
5150

5251
override fun onCreate(savedInstanceState: Bundle?) {
5352
super.onCreate(savedInstanceState)
54-
Fabric.with(this, Crashlytics())
5553

5654
binding = DataBindingUtil.setContentView(this, R.layout.activity_main)
5755

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package co.kyash.vtl.example.api
22

3-
import io.reactivex.Single
3+
import io.reactivex.rxjava3.core.Single
44
import retrofit2.http.GET
55

66
interface MaterialDesignColorsApi {
77

88
@GET("/Kyash/validatable-textinput-layout/master/json/colors.json")
99
fun all(): Single<List<String>>
1010

11-
}
11+
}

example/src/main/java/co/kyash/vtl/example/validators/MaterialDesignColorsValidator.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import co.kyash.vtl.VtlValidationFailureException
55
import co.kyash.vtl.example.R
66
import co.kyash.vtl.example.api.MaterialDesignColorsApi
77
import co.kyash.vtl.validators.VtlValidator
8-
import io.reactivex.Completable
9-
import io.reactivex.Single
8+
import io.reactivex.rxjava3.core.Completable
9+
import io.reactivex.rxjava3.core.Single
1010

1111
class MaterialDesignColorsValidator(
1212
private val api: MaterialDesignColorsApi,
@@ -33,4 +33,4 @@ class MaterialDesignColorsValidator(
3333
return context.getString(R.string.validation_error_colors)
3434
}
3535

36-
}
36+
}

gradle/wrapper/gradle-wrapper.jar

5.76 KB
Binary file not shown.
+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
#Fri Apr 06 07:32:45 JST 2018
21
distributionBase=GRADLE_USER_HOME
32
distributionPath=wrapper/dists
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip

0 commit comments

Comments
 (0)