Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting of low-level Kafka options with auth options #2

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

lxnewayfarer
Copy link
Contributor

@lxnewayfarer lxnewayfarer commented Jan 27, 2025

Context

There was a problem with Kafka authorization due to the fact that the auth options overwritten the low-level kafka_config options. As a result, we could not use SASL_SSL authorization with an SSL certificate.
I fixed the line where the Kafka configuration was overwritten with the default authorization options. This looks more logical, and makes it possible to configure the connection to Kafka through the low-level config.

What's inside

Checklist:

  • I have added tests
  • I have made corresponding changes to the documentation

@bibendi
Copy link
Member

bibendi commented Jan 27, 2025

Hi! Thanks for the PR! It seems that the more correct solution would be to refine the auth config so that it understands SASL_SSL authorization. But nevertheless, definitely the auth section should certainly not overwrite low-level options. I think, we should keep this fix.

@lxnewayfarer
Copy link
Contributor Author

@bibendi can you please tell me when it can be expected to be merged?

@bibendi bibendi merged commit 9008ce3 into Kuper-Tech:master Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants