Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR Template #650

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Add PR Template #650

merged 1 commit into from
Mar 12, 2025

Conversation

trepel
Copy link
Contributor

@trepel trepel commented Mar 12, 2025

Description

Adds PR template so people are reminded of importance of proper PR description

Verification Steps

I don't think that it is possible to validate this before getting this merged so eye review must suffice.

Signed-off-by: Tomas Repel <[email protected]>
Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be two headers?

# Description
...

# Verification steps
...

I dont know how the syntax works so I trust you. Approved 👍

@trepel
Copy link
Contributor Author

trepel commented Mar 12, 2025

Should there not be two headers?

Well, I did not want to make verification steps mandatory so I put it (and few other things that came to my mind) into comment. It is only meant as a reminder. The comment will only be visible if "Write" tab is active, if editing the PR description in "Preview" tab, you won't see it.

For sure we can iterate and update this template. We can discuss again next week after one week of using the template as is in this PR.

@trepel trepel merged commit 444731f into Kuadrant:main Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants