-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for D&O merge strategy #638
Add tests for D&O merge strategy #638
Conversation
testsuite/tests/singlecluster/defaults/merge/same_target/test_ab_strategy.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/defaults/merge/same_target/test_ba_startegy.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/defaults/merge/test_gateway_default_merge.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/defaults/merge/same_target/test_ab_strategy.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/overrides/merge/same_target/test_ab_strategy.py
Outdated
Show resolved
Hide resolved
I don't like two additional things:
|
Signed-off-by: averevki <[email protected]>
961870d
to
5804d44
Compare
good idea, done
agreed, there are a lot of other tests doing that inside the testsuite though. We can do another single PR with all these changes in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks!
Refined part of #608 with merge strategy tests only
Closes #566