Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make order of desired and exsting object persistent throughout mutators #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Patryk-Stefanski
Copy link

The order in which the desired and existing objects are passed through the mutator functions should be consistent to avoid confusion when reading.

@Patryk-Stefanski Patryk-Stefanski force-pushed the makeMutatorsOrderingMakeSense branch 2 times, most recently from fe0ef7c to b4d9ecc Compare March 11, 2025 16:32
@eguzki
Copy link
Contributor

eguzki commented Mar 12, 2025

LGTM, let's see the tests

@Patryk-Stefanski Patryk-Stefanski force-pushed the makeMutatorsOrderingMakeSense branch 2 times, most recently from 6c74be3 to 17d3380 Compare March 14, 2025 14:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (515d57b) to head (d90ce9a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   83.71%   82.97%   -0.75%     
==========================================
  Files          18       18              
  Lines        1210     1210              
==========================================
- Hits         1013     1004       -9     
- Misses        150      156       +6     
- Partials       47       50       +3     
Flag Coverage Δ
integration 76.52% <100.00%> (-1.58%) ⬇️
unit 63.64% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <ø> (ø)
pkg/helpers (u) 83.78% <ø> (ø)
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 73.26% <100.00%> (ø)
pkg/limitador (u) 97.65% <ø> (ø)
controllers (i) 72.77% <100.00%> (-2.30%) ⬇️
pkg/upgrades ∅ <ø> (∅)
Files with missing lines Coverage Δ
controllers/limitador_controller.go 70.27% <100.00%> (-2.10%) ⬇️
pkg/reconcilers/base_reconciler.go 50.89% <100.00%> (ø)
pkg/reconcilers/deployment.go 95.86% <100.00%> (ø)
pkg/reconcilers/poddisruptionbudget.go 30.00% <100.00%> (ø)
pkg/reconcilers/service.go 76.92% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Patryk-Stefanski
Copy link
Author

/retest

@Patryk-Stefanski Patryk-Stefanski force-pushed the makeMutatorsOrderingMakeSense branch from 17d3380 to d90ce9a Compare March 14, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants