Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Workflow Configuration #1202

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix Workflow Configuration #1202

merged 1 commit into from
Mar 13, 2025

Conversation

Boomatang
Copy link
Contributor

The workflow steps has no field needs. This was causing the action to fail.

@Boomatang Boomatang requested a review from a team as a code owner March 13, 2025 11:26
The workflow steps has no field needs

Signed-off-by: Jim Fitzpatrick <[email protected]>
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.1@456ac9f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-v1.1    #1202   +/-   ##
===============================================
  Coverage                ?   83.50%           
===============================================
  Files                   ?       82           
  Lines                   ?     7117           
  Branches                ?        0           
===============================================
  Hits                    ?     5943           
  Misses                  ?      942           
  Partials                ?      232           
Flag Coverage Δ
bare-k8s-integration 23.54% <ø> (?)
controllers-integration 74.07% <ø> (?)
envoygateway-integration 41.22% <ø> (?)
gatewayapi-integration 20.23% <ø> (?)
istio-integration 44.19% <ø> (?)
unit 19.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.78% <0.00%> (?)
api/v1beta2 (u) ∅ <0.00%> (?)
pkg/common (u) ∅ <0.00%> (?)
pkg/istio (u) 62.06% <0.00%> (?)
pkg/log (u) 93.18% <0.00%> (?)
pkg/reconcilers (u) 24.50% <0.00%> (?)
pkg/rlptools (u) ∅ <0.00%> (?)
controllers (i) 86.68% <0.00%> (?)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@didierofrivia didierofrivia mentioned this pull request Mar 13, 2025
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re run the failing tests, then port the commit to the release-process-enchancement branch too

@Boomatang Boomatang merged commit a5a35e7 into release-v1.1 Mar 13, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants