Coredns plugin #403
Coredns plugin #403
Conversation
Adds a new coredns plugin with a "kuadrant" directive. Signed-off-by: Michael Nairn <[email protected]>
Signed-off-by: Maskym Vavilov <[email protected]>
| @@ -0,0 +1,2 @@ | |||
| # kuadrant CoreDNS Plugin | |||
|
|
|||
There was a problem hiding this comment.
Do we expect others might want to make use of this in their own core dns? Should we add more details and consider making it available to others to use?
There was a problem hiding this comment.
I intend to add some content to this README before i move it from draft, but in terms of someone wanting to include this plugin in their own CoreDNS then it would be done in the same way as any other external plugin as described here.
mikenairn
force-pushed
the
coredns_plugin
branch
4 times, most recently
from
0e306b9 to
fbe4693
Compare
* Update example Corefie and remove file directive * Move the db-generator under plugin so the demo db can more easily be built and embedded in the coredns image. * Add make target to generate demo db `make coredns-generate-demo-geo-db`. * Fix imports and code formatting. Signed-off-by: Michael Nairn <[email protected]>
Adds a anew buid images github action for the kuadrant CoreDNS plugin. Add coredns_plugin to branches (DO NOT MERGE) Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
coredns_plugin
branch
from
fbe4693 to
8bec8a7
Compare
| var answer *dns.RR | ||
| var geoRRs []geodRR | ||
|
|
||
| roundRobinShuffle(grrs) |
There was a problem hiding this comment.
This should probably be removed, but it makes me wonder what we would like the default behaviour to be when we can't match any geo to the current request. Do we want it to always just return the first RR in the list?
Currently this will cause it to randomise what it would return if there are multiple geos available.
There was a problem hiding this comment.
I think we should leverage the default GEO like AWS
coredns/plugin/cmd/coredns.go
Outdated
| for _, name := range dnsserver.Directives { | ||
|
|
||
| if dropPlugins[name] { | ||
| if !alreadyAdded { |
There was a problem hiding this comment.
This reads a bit odd? Like it should be outside of the if?
| }, | ||
| }, | ||
| &v1alpha1.DNSRecord{}, | ||
| defaultResyncPeriod, |
There was a problem hiding this comment.
does it matter that we are passing 0 as default? Not sure what that means
mikenairn
force-pushed
the
coredns_plugin
branch
2 times, most recently
from
6a7f364 to
a9b1b88
Compare
Limit the number of plugins included by default in the kuadrant build of CoreDNS. The plugins enabled are the required ones and more simple plugins with few additional dependencies but are useful for debug/testing purposes. The `trace` plugin had licensing issues and was the main reason to reduce the plugin imports. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
coredns_plugin
branch
from
a9b1b88 to
173ceb8
Compare
| sort.Slice(address, func(i, j int) bool { | ||
| return address[i].weight > address[j].weight | ||
| }) | ||
| v := w.randUint(wsum) |
There was a problem hiding this comment.
So generates a random number between 0 and the sum of all the weights. Then orders the addresses by weight desc and returns the first result that has a weight or combined weight greater than the random value. So if you have a weight of 200 and another of 100 you end up with 300 and a random number between 0 and 300 picked so you are twice as likely to get one < 200 than you are to get one between >= 200 <= 300. So kinda like a weighted coin flip it wont be super predictable but will give you the weighting. At least this is how I read it
| file.NewZone(name, ""), | ||
| map[dns.RR]rrData{}, | ||
| } | ||
|
|
There was a problem hiding this comment.
might be worth adding a comment that highlights this gets called multiple times otherwise at first reading seems only GEO or Weighted rather than Geo and Weighted
No description provided.