-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Implement soft_delete and stop_soft_delete flags in the plan #384
Open
philbrookes
wants to merge
1
commit into
Kuadrant:main
Choose a base branch
from
philbrookes:gh-356-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e611f26
to
434d3e7
Compare
434d3e7
to
5557b54
Compare
e27b216
to
d2337c3
Compare
00ea5f7
to
ddfa5af
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mikenairn
reviewed
Feb 27, 2025
This comment was marked as outdated.
This comment was marked as outdated.
00dcb31
to
90aeb15
Compare
mikenairn
reviewed
Mar 6, 2025
mikenairn
reviewed
Mar 6, 2025
5e97eab
to
8a3e6a7
Compare
Signed-off-by: Phil Brookes <[email protected]>
maksymvavilov
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some useful DNS Records for local testing (will require some tweaking e.g. hostnames): https://gist.github.com/philbrookes/617e03b739f43f01423f9ea94284333d
To test having one or more removed, edit the following:
To look like:
As discussed, this will not cover removing the label on cluster1 and cluster2 simultaneously (i.e. race conditions) that will be covered in future work: #385