Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Implement soft_delete and stop_soft_delete flags in the plan #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philbrookes
Copy link
Contributor

@philbrookes philbrookes commented Feb 21, 2025

Some useful DNS Records for local testing (will require some tweaking e.g. hostnames): https://gist.github.com/philbrookes/617e03b739f43f01423f9ea94284333d

To test having one or more removed, edit the following:

    - dnsName: cluster1-gw1-ns1.klb.loadbalanced.pb.hcpapps.net
      recordTTL: 60
      recordType: A
      targets:
        - 172.18.200.1

To look like:

    - dnsName: cluster1-gw1-ns1.klb.loadbalanced.pb.hcpapps.net
      recordTTL: 60
      recordType: A
      targets:
        - 172.18.200.1
      labels:
        soft_delete: "true"
  • mark cluster1 or cluster2 individually for removal, to see it removed.
  • mark cluster3 for removal and it will not remove (only record in the GEO)
  • mark cluster1 for removal, then afterwards cluster2 and see cluster1 removed but not cluster2 (last record in GEO).

As discussed, this will not cover removing the label on cluster1 and cluster2 simultaneously (i.e. race conditions) that will be covered in future work: #385

@philbrookes philbrookes force-pushed the gh-356-2 branch 21 times, most recently from e611f26 to 434d3e7 Compare February 24, 2025 13:08
@philbrookes philbrookes changed the title [WIP] Gh 356 2 [feature] Implement soft_delete and stop_soft_delete flags in the plan Feb 24, 2025
@philbrookes philbrookes force-pushed the gh-356-2 branch 3 times, most recently from e27b216 to d2337c3 Compare February 26, 2025 11:26
@philbrookes

This comment was marked as resolved.

mikenairn

This comment was marked as outdated.

@philbrookes

This comment was marked as outdated.

@philbrookes philbrookes force-pushed the gh-356-2 branch 4 times, most recently from 00dcb31 to 90aeb15 Compare March 5, 2025 17:33
@philbrookes philbrookes force-pushed the gh-356-2 branch 5 times, most recently from 5e97eab to 8a3e6a7 Compare March 6, 2025 15:56
Copy link
Contributor

@maksymvavilov maksymvavilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement changes to plan to use soft delete flag to remove records
3 participants