[GeoMechanicsApplication] Convert two stage line loads test to the orchestrator based analysis and test #13057
Conversation
There was a problem hiding this comment.
Thank you so much for investigating how to convert the original two-stage test to a test that uses the orchestrator. The result of your efforts show clearly what is needed to run multi-stage analysis with this novel approach. Well done!
I have a few suggestions that you may find helpful.
...hanicsApplication/tests/line_load_tests/line_loads_with_orchestrator/MaterialParameters.json
Outdated
Show resolved
Hide resolved
...hanicsApplication/tests/line_load_tests/line_loads_with_orchestrator/MaterialParameters.json
Outdated
Show resolved
Hide resolved
...cations/GeoMechanicsApplication/tests/line_load_tests/line_loads_with_orchestrator/README.md
Outdated
Show resolved
Hide resolved
...cations/GeoMechanicsApplication/tests/line_load_tests/line_loads_with_orchestrator/README.md
Outdated
Show resolved
Hide resolved
...hanicsApplication/tests/line_load_tests/line_loads_with_orchestrator/MaterialParameters.json
Outdated
Show resolved
Hide resolved
|
Hi @rubenzorrilla , here is our first case with the orchestrator. Please could you have a brief look at it? Perhaps, you may suggest some improvements. Thank you. |
| @@ -218,6 +218,9 @@ def RunSolutionLoop(self): | |||
| self.FinalizeSolutionStep() | |||
| self.OutputSolutionStep() | |||
|
|
|||
| # For orchestrator-based multi-stage analyses, we need to register our own analysis stage class | |||
| Kratos.Registry.AddItem("Stages.KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis.GeoMechanicsAnalysis.ClassName", "GeoMechanicsAnalysis") | |||
| Kratos.Registry.AddItem("Stages.KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis.GeoMechanicsAnalysis.ModuleName", "KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis") | |||
There was a problem hiding this comment.
I would suggest to add one (or perhaps even two) blank line(s) after these lines, to clearly separate them from the next line (if __name__ == '__main__':), since they are unrelated.
| # For orchestrator-based multi-stage analyses, we need to register our own analysis stage class | ||
| Kratos.Registry.AddItem("Stages.KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis.GeoMechanicsAnalysis.ClassName", "GeoMechanicsAnalysis") | ||
| Kratos.Registry.AddItem("Stages.KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis.GeoMechanicsAnalysis.ModuleName", "KratosMultiphysics.GeoMechanicsApplication.geomechanics_analysis") |
There was a problem hiding this comment.
This should be placed in the registry lists to happen when importing the application module. Note that current implementation implies that the happens when importing the stage module, something that precludes using the registry as a factory.
See an example in the FluidDynamicsApplication here and here.
📝 Description
A brief description of the PR.