Skip to content

Temporary fix for Kotlin ABI Validation #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: kotlin-community/k2/dev
Choose a base branch
from

Conversation

shanshin
Copy link
Contributor

Artifact org.jetbrains.intellij.deps:asm-all is published only in Intellij Deps repository, checkLegacyAbi and updateLegacyAbi require this dependency since Kotlin 2.3.

This is temporary fix until https://jetbrains.team/p/kt/reviews/23039/timeline is merged

@shanshin shanshin requested a review from fzhinkin August 12, 2025 17:11
@fzhinkin fzhinkin requested a review from murfel August 12, 2025 17:41
@fzhinkin
Copy link
Contributor

The change is only required for the kotlin-community branch, let's merge (and later revert it) there.
There's no way we will compile this branch with Kotlin 2.3 prior the 2.3's release, and the problem will be solved on the Kotlin side by then.

@shanshin shanshin changed the base branch from develop to kotlin-community/dev August 12, 2025 18:20
@shanshin shanshin changed the base branch from kotlin-community/dev to develop August 12, 2025 18:23
@shanshin
Copy link
Contributor Author

The change is only required for the kotlin-community branch, let's merge (and later revert it) there. There's no way we will compile this branch with Kotlin 2.3 prior the 2.3's release, and the problem will be solved on the Kotlin side by then.

kotlin-community/dev is very outdated, and develop was used to run tests

@fzhinkin
Copy link
Contributor

@shanshin, it's kotlin-community/k2/dev :D

The branch in question was bobova/rebase-12Aug, which is the k2/dev rebased on top of develop.

Artifact org.jetbrains.intellij.deps:asm-all is published only in Intellij Deps repository.
Since the checkLegacyAbi and updateLegacyAbi updateLegacyAbi require this dependency since Kotlin 2.3.

This is temporary fix until https://jetbrains.team/p/kt/reviews/23039/timeline is merged
@shanshin shanshin changed the base branch from develop to kotlin-community/k2/dev August 12, 2025 19:39
@shanshin shanshin removed the request for review from murfel August 12, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants