Simplify kotlinx-coroutines-core build script #4344
Merged
+2
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been used to test that the core can compile against 1.6 JVM target, but since coroutines jvm jar ships all classfiles for jvm 1.8+ since 1.5.0 This clean up is needed to promote KotlinCompilation.source API to an error deprecation ^KT-64991
abdulowork
force-pushed
the
timofey.solonin/KT-64991-remove-KotlinCompilation.source-usages
branch
from
8b0cee0 to
4942f0b
Compare
|
Cool, thanks! I didn't know Kotlin builds were reproducible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This split in source sets and compilations seems to have been used to test that the core can compile against the 1.6 JVM target, but the coroutines jvm jar ships class files for jvm 1.8+ since 1.5.0.
We need this cleanup to promote KotlinCompilation.source API to an error deprecation.
I tested manually that there is no impact on the resulting jar: