Skip to content

Conversation

Jozott00
Copy link
Collaborator

@Jozott00 Jozott00 commented Sep 4, 2025

Subsystem
gRPC/Native

Solution
This PR adds a gRPC server implementation for K/N.
It uses the same C-Core callback API as the C++ callback server implementation. This way, we don't have to provide our own thread pool to request incoming calls from the server.

@Jozott00 Jozott00 self-assigned this Sep 4, 2025
@Jozott00 Jozott00 added the feature New feature or request label Sep 4, 2025
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
@Jozott00 Jozott00 marked this pull request as ready for review September 5, 2025 13:40
@Jozott00 Jozott00 requested a review from Mr3zee September 5, 2025 13:40
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lightning fast!
I pressed request changes as I want to discuss the questions below

Signed-off-by: Johannes Zottele <[email protected]>
@Jozott00 Jozott00 requested a review from Mr3zee September 5, 2025 18:37
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Jozott00 Jozott00 merged commit 565ea07 into grpc-common Sep 9, 2025
5 of 6 checks passed
@Jozott00 Jozott00 deleted the grpc/native-server branch September 11, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants