Update createDataFrame.md with compiler-plugin friendly examples #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
documentation
koperagen
force-pushed
the
plugin-friendly-examples-update
branch
from
d836c6e to
0a65d11
Compare
koperagen
force-pushed
the
plugin-friendly-examples-update
branch
from
0a65d11 to
8861f89
Compare
koperagen
force-pushed
the
plugin-friendly-examples-update
branch
from
8861f89 to
b51f36a
Compare
Jolanrensen
approved these changes
Oct 27, 2025
| // SampleStart | ||
| val categories = listOf("Electronics", "Books", "Clothing") | ||
| // DataFrame with 4 columns and 7 rows | ||
| (0 until 7).toDataFrame { |
There was a problem hiding this comment.
maybe nice to show off ..< instead of until :) but up to you
| "reviews" from { | ||
| val reviewCount = Random.nextInt(0, 8) | ||
| (0 until reviewCount).toDataFrame { | ||
| val ratings: DataColumn<Int> = expr { Random.nextInt(1, 6) } |
There was a problem hiding this comment.
could you use the Kotlin Random extension functions which take ranges instead? :) With those it's immediately clear which number is included and which is not Random.nextInt(1..5), whereas with Random.nextInt(1, 6) I'd have to know 6 is excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced some examples that don't work with compiler plugin and use outdated API that we plan to replace, with
toDataFrameoperation.Now examples with random data can be copy-pasted into project with compiler plugin. Plus, generally it's much more powerful approach that can produce sophisticated dataframes:
In the process i found that our rendering doesn't work for some of the examples and fixed it.
