generateCode.kt refactor, KDocs, documentation fixes, and tests #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
changed the title
Jolanrensen
added
KDocs
Jolanrensen
changed the title
koperagen
reviewed
Jul 4, 2025
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/CodeGenerationTests.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Jul 4, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
…rateCode.kt from feedback
…ed generateCode.kt from feedback
Jolanrensen
changed the title
Jolanrensen
added
enhancement
Jolanrensen
changed the title
|
@AndreiKingsley @koperagen Alright, I decided to refactor the API as well:
Please check again as many things have changed :) I did take your feedback into account |
AndreiKingsley
approved these changes
Jul 22, 2025
docs/StardustDocs/topics/concepts/DataSchemaGenerationMethods.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281