fix(cli): complete version protocol follow-ups#45
Open
tkkhq wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Completes CLI-side version protocol handling for development builds and long-running log streams.
Changes:
- Reports source builds as
devwhile preserving diagnostic User-Agent data. - Displays and consumes API notices when log streams open.
- Expands protocol, login, stream, and state-cleanup tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/logfollow/follow.go |
Adds stream-open callbacks. |
internal/cmd/upgrade/upgrade.go |
Consumes one-shot notices. |
internal/cmd/upgrade/upgrade_test.go |
Tests deprecation and cleanup. |
internal/cmd/functions/logs.go |
Prints notices before following logs. |
internal/cmd/functions/logs_test.go |
Tests runtime-follow notices. |
internal/cmd/frontends/logs.go |
Prints notices before following logs. |
internal/cmd/frontends/logs_test.go |
Tests runtime-follow notices. |
internal/api/version_protocol.go |
Adds consumption and development-version reporting. |
internal/api/version_protocol_test.go |
Tests version classification and consumption. |
internal/api/log_stream_test.go |
Tests stream protocol headers. |
cmd/volcano/main_test.go |
Expands end-to-end notice and login coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
+82
| lastInstructions.CLIInstruction = "" | ||
| lastInstructions.LatestVersion = "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #39 that completes the CLI-side version-protocol fixes:
devrequest version for source, dirty, and detached-revision builds while preserving the full build identifier inUser-Agentand preserving release/nightly version forms.--followblocks; consume the one-shot instruction so it is not printed again when command execution returns./auth/*device-flow login, and sticky global-state cleanup.Audience
httptestcases, including source-build and login flows.Test
go build ./...go test ./... -count=1go test -race ./internal/api ./internal/cmd/upgrade ./internal/cmd/functions ./internal/cmd/frontends ./cmd/volcano -count=1