-
Notifications
You must be signed in to change notification settings - Fork 26
Initial layout for matrices #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
===========================================
- Coverage 81.02% 70.96% -10.07%
===========================================
Files 10 10
Lines 585 675 +90
===========================================
+ Hits 474 479 +5
- Misses 111 196 +85
☔ View full report in Codecov by Sentry. |
|
I think if the primitive type |

This builds on the work in #56 (which itself builds on #50). All those commits
have been rebased onto master for convience.
I implemented a simple layout algorithm for matrices (only supports
matrixright now, but extending to include
pmatrixandbmatrixshould be possible).It works quite well for simple entries, although perhaps the entries should be
centered horizontally and vertically.
test.pdf
However, you can see that the layout is very poor when taller notation (e.g.
fractions) are used. I think this results from a misunderstanding on my part of
how they layout is done. In the second attached pdf, you can see pairs of
horizontal lines where I think the symbols should be, which disagrees quite
dramatically with where they are.
test_vert_extent.pdf