Add TVER factory check

[0xAurelius]

Still needs tests, upgrade script, etc.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
solidity	🔄 Building (Inspect)	Visit Preview		Mar 12, 2025 8:07pm

[Atmosfearful]

Short-circuit evaluation would defer external contract calls until the preceding calls fail. Which saves gas for CMARK retirements (but not for TVER retirements).

function isValid(address token) internal view returns (bool) {
    return bytes(ICMARKCreditTokenFactory(C.cmarkCreditFactory()).creditAddressToId(token)).length > 0 ||
           bytes(ICMARKCreditTokenFactory(C.tverCreditFactory()).creditAddressToId(token)).length > 0;
}

When consulting the AI it also surfaced this:

view Modifier:
Marking the function as view (assuming creditAddressToId is also view) clarifies that no state modifications occur, potentially lowering gas costs when called externally.

And it also taught me something subtle (not relevant, just interesting):

Directly referencing constants can save gas compared to calling a function—if those constants are available in a way that avoids a function call overhead. However, in this case, the getters in C.sol are defined as internal pure functions. With Solidity’s optimizer enabled, these internal pure function calls are usually inlined at compile time. This means that in an optimized build, there’s effectively no gas difference between using the getter functions and referencing the constants directly (if that were possible).

So, while direct constant access might theoretically be marginally cheaper, here the impact is negligible due to inlining by the compiler.