[DRAFT] Retirement batches #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
psparacino
requested changes
Feb 27, 2025
This reverts commit 0c66d5c.
biwano
commented
Mar 5, 2025
biwano
commented
Mar 10, 2025
|
|
||
| AppStorage internal s; | ||
|
|
||
| /** Handles non reentrance for single retirement transactions */ | ||
| modifier nonReentrant() { |
There was a problem hiding this comment.
@brendan Reentrency guard only on the batchRetire function?
psparacino
reviewed
Mar 10, 2025
psparacino
reviewed
Mar 11, 2025
| (bool success, bytes memory data) = diamondAddress.delegatecall(calls[i].callData); | ||
|
|
||
| // Extract the call result | ||
| if (success && data.length == 32) { |
There was a problem hiding this comment.
if we want to fully abstract this batchCall we should remove the data length success condition for any void functions or return types like other bytes/strings etc. In that case we could just return raw bytes and decode offchain based on the function called.
There was a problem hiding this comment.
Done in f531024
I did a bit of refactoring. Since we return whole bytes. I also send the success boolean in the event and in the function return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchRetireFacetthat enables doing multiple retirements in one transaction. With tests.Diamond. With tests.ReentrancyGuardto support batchingupgradeCurrentDiamondmethod to support the BatchRetireFacetgetSourceTokensWithSlippagehelper methodadjustedAmountOutinLibSwapIQuoterView.solinterface and updates referencesfoundryversion in theREADME