chore(ImageMarchingCubes): fix example clipping - #3641
Open
Jo-Byr wants to merge 1 commit into
Open
Conversation
Update sample bounds on radius and iso value updates to avoid clipping of output with bounds Set initial GUI radius to actual sphere's initial radius
finetjul
reviewed
Sep 8, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
I do not think there is a problem in the first place. The clipping makes sense and helps understand what the algorithm really does.
Showing the "sample" volume (don't do it) could be more helpful than changing the bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The produces sphere in ImageMarchingCubes example can clip with the sampler bounds for a big enough radius or ISO value.
Results
Bounds are updated when changing radius or ISO to prevent clipping.
Changes
Update sample bounds on radius and iso value updates to avoid clipping of output with bounds
Set initial GUI radius to actual sphere's initial radius
PR Checklist