Skip to content

feat(IDE): enable Go To Definition feature#3518

Open
daker wants to merge 1 commit into
Kitware:masterfrom
daker:vscode-gotodef
Open

feat(IDE): enable Go To Definition feature#3518
daker wants to merge 1 commit into
Kitware:masterfrom
daker:vscode-gotodef

Conversation

@daker

@daker daker commented May 24, 2026

Copy link
Copy Markdown
Collaborator

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Comment thread .vscode/extensions.json
Comment thread .vscode/extensions.json
{
"recommendations": [
"EditorConfig.EditorConfig",
"yoavbls.pretty-ts-errors"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same idea - IMHO, this is very much user-preference.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only to inform users about the recommended VS Code extensions. Without EditorConfig.EditorConfig, the .editorconfig file in the project will not be applied, which can lead to PR issues such as incorrect EOLs, indentation, and other formatting inconsistencies.

Comment thread .vscode/settings.json
Comment thread jsconfig.json
Comment thread package.json
@daker
daker requested a review from sankhesh June 1, 2026 09:04

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @jourdain @PaulHax :

  • please move the package.json change into a different "commit".
  • do not commit .vscode files in the repository, but you can add those in the github page documentation.
  • ok to keep jcsonfig.json
  • the commit message is not a "feat" but a "docs" or "chore (to not trigger a new release).

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants