testing branch for new girder_worker_api_url environment variable#1767
Draft
BryonLewis wants to merge 2 commits into
Draft
testing branch for new girder_worker_api_url environment variable#1767BryonLewis wants to merge 2 commits into
BryonLewis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #1766
Testing branch for a new PR of girder to add override api url enviroment variable for workers: girder/girder#3874
Tested and it seemed to work with an external worker and an internal worker, given that rabbitmq port was exposed properly as well as the girder api at
/api/v1I'll probably delete the test folder and update the documentation in this branch once I've merged in the Girder PR.