Repository navigation
Propagate SubProject filters from index.php to the build tests page - #4083
Merged
williamjallen merged 1 commit intoOct 13, 2026
Conversation
Contributor
Author
|
Here's an example screenshot of what this looks like using our 
|
williamjallen
requested changes
Oct 9, 2026
williamjallen
left a comment
williamjallen
left a comment
Collaborator
There was a problem hiding this comment.
The overall approach looks like a reasonable temporary solution until the index page is refactored and we're able to build a more integrated subprojects UI. I didn't find any issues in manual testing.
A couple comments:
- Removing label filter propagation was deliberate (#3724). Should this be classified as feature instead of a fix?
- The
childFiltersquery parameter feels poorly named to me. Instead of encoding full filters, would it be better to just have asubprojects=a,b,cquery parameter, and then let JS convert that list to filters?
When index.php is filtered to include or exclude a set of SubProjects, the test counts it displays only reflect the selected SubProjects, but the build tests page linked from those counts showed tests from every SubProject. index.php now appends the selected SubProjects to the test count links as subprojects[] (include) or excludeSubprojects[] (exclude) query parameters. The build tests page converts these to a GraphQL filter on the child builds it queries (including the previous build used for onlydelta), and displays a notice with a link to show all SubProjects.
zackgalbreath
force-pushed
the
propagate-subproject-filters-to-tests-page
branch
from
October 13, 2026 19:13
25ef63d to
40756bd
Compare
williamjallen
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SubProjects include/exclude filter on index.php used to be passed along to viewTest.php, but this functionality was lost when we switched to the GraphQL-based builds/{id}/tests page.
This commit restores the functionality by generating a GraphQL child build filter and appending it to the link to the build tests page. This page now displays a notice when results are being filtered by SubProject, including a link to show tests for all SubProjects.