Fix 'should edit a scale call with factor' codemod test #9020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
commented
Nov 21, 2025
Comment on lines
+317
to
+321
| const nodeToEdit: PathToNode = [ | ||
| ['body', ''], | ||
| [3, 'index'], | ||
| ['expression', 'ExpressionStatement'], | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
This was the real fix! Of course we didn't want a path to node to the last variable 🤦
We only went into recast territory deep in getNodeFromPath cause it was failing
…call-with-factor-codemod-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8994
And clean up some shared helpers along the way.