Skip to content

kcl- Absolute control points for bezier curves #7083 #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rajgandhi1
Copy link
Contributor

Screen.Recording.2025-05-21.at.12.57.57.PM.mov

Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:42am

Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Instrumentation Performance Report

Merging #7141 will not alter performance

Comparing rajgandhi1:kcl-absolute_value_bezier (f04e4d7) with main (ab63345)

Summary

✅ 78 untouched benchmarks

@adamchalmers
Copy link
Contributor

@rajgandhi1 Thanks for the PR! I really appreciate it. KCL usually gives users the option per-argument to choose relative vs. absolute, so I'm going to close this PR and use this implementation instead: #7172 -- but feel free to ping me if you're interested in implementing more KCL! We should have added the proposed arguments to the GitHub issue, so that you wouldn't waste your time implementing something that wasn't quite what we had in mind. Sorry mate!

@rajgandhi1
Copy link
Contributor Author

@adamchalmers Sure no issues. I would love to implement more. Will ping you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants