reexecute KCL code when reloading due to external file modification #7039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7029
I've verified this fixes the issue by running the modeling-app locally on my machine via
npm run tronb:package:dev.I'm not familiar with this codebase but it seems we were just missing the call to re-evaluate the KCL.
If its significantly more involved than this I can close the PR and defer to the zoo team.
Unlike the
isImportedInCurrentFilecase, I found that for theisCurrentFilecase,executeAstis not sufficient. InsteadexecuteCode(which callsexecuteAst) is required.