Update fillet+chamfer with new API options #6745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CodSpeed Instrumentation Performance ReportMerging #6745 will not alter performanceComparing Summary
|
adamchalmers
force-pushed
the
achalmers/new-fillet-options
branch
3 times, most recently
from
75072e0 to
ca93fb7
Compare
adamchalmers
force-pushed
the
achalmers/new-fillet-options
branch
from
ca93fb7 to
8f7ef49
Compare
jessfraz
approved these changes
May 7, 2025
nrc
reviewed
May 7, 2025
| @settings(defaultLengthUnit = mm, kclVersion = 1.0) | ||
|
|
||
| /// Try the fast but simple Basic strategy, and if that fails, try the slow and complex CSG strategy. | ||
| export automatic = "automatic" |
There was a problem hiding this comment.
Could these be all caps like the turns and maths constants?
| @@ -71,6 +71,8 @@ export fn fillet( | |||
| tolerance?: number(Length), | |||
| /// Create a new tag which refers to this fillet | |||
| tag?: tag, | |||
| /// Which strategy should be used to perform this chamfer? | |||
There was a problem hiding this comment.
Suggested change
| /// Which strategy should be used to perform this chamfer? | |
| /// Which strategy should be used to perform this fillet? |
| for _ in 0..num_extra_ids { | ||
| extra_face_ids.push(exec_state.next_uuid()); | ||
| } | ||
| let strategy = strategy.unwrap_or_default(); |
There was a problem hiding this comment.
We should warn or error on a bad strategy, at the moment a typo in a string literal will silently use the default
|
closing in favor of #6750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine recently improved edge cuts (i.e. fillets/chamfers):
fillet(strategy = cutStrategy::basic)instead.