Make 'npm run test:rust' work out-of-the-box #6721
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacebrowning
force-pushed
the
fix-rust-test
branch
2 times, most recently
from
9899a57 to
213be1b
Compare
jacebrowning
force-pushed
the
fix-rust-test
branch
from
213be1b to
94acb34
Compare
jacebrowning
force-pushed
the
fix-rust-test
branch
from
94acb34 to
d0d9895
Compare
jacebrowning
force-pushed
the
fix-rust-test
branch
from
d0d9895 to
4896b07
Compare
|
|
||
| RUST_BACKTRACE="full" | ||
| PYO3_PYTHON=/usr/local/bin/python3 | ||
| #KITTYCAD_API_TOKEN="required token from dev.zoo.dev for engine testing" |
There was a problem hiding this comment.
Do the Rust tools read this file?
There was a problem hiding this comment.
What I'm trying to say is, I don't think any of the Rust tools read this file or the .local one. So by removing RUST_BACKTRACE="full" from the justfile and adding it here, I don't think the functionality is preserved. I don't personally use just test, so it doesn't really bother me. I'm going to use my own environment variables anyway. (I've been using direnv for times when I don't control the invocation.) But maybe you want to know.
There was a problem hiding this comment.
They don't explicitly need this file. This is merely a convenient way of enumerating all environment variables with defaults and a way to override them.
| #VITE_KC_DEV_TOKEN="your token from dev.zoo.dev should go in .env.development.local" | ||
| #VITE_KC_DEV_TOKEN="optional token from dev.zoo.dev to skip auth in the app" | ||
|
|
||
| RUST_BACKTRACE=1 |
There was a problem hiding this comment.
I actually couldn't find docs on it, but it's essentially verbosity level. If you hit a Rust panic without it set, the CLI error message literally tells you to set it to full.
just testshould, well, just work by installing our chosen test runner automatically.I also removed a section of
CONTRIBUTING.mdthat was already stale and I plan to revisit.Contributes to #4012