refactor: split statistics sketch storage and add RocksDB diagnostics#312
Merged
refactor: split statistics sketch storage and add RocksDB diagnostics#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue link:
What is changed and how it works?
collect_countactually needs it.StatisticsMetaCacheto cache both positive entries and negative lookup results viaOption, so repeated misses do not keep hitting storage.ANALYZE, storage codecs, and transaction APIs to read/write the new statistics layout.0.1.8for the next publish.Code changes
Check List
Tests
Manual test steps:
cargo test test_analyze --libcargo check -p tpcc -p kite_sqlcargo run -p tpcc --release -- --backend kite --measure-time 60 --num-ware 1 --rocksdb-stats --path /tmp/kitesql_tpcc_phase_metricsSide effects
Note for reviewer