MacOs / Terminal Notifier Support #2299
Conversation
🦋 Changeset detectedLatest commit: a4cc290 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds enhanced macOS notification support with terminal-notifier integration while maintaining backward compatibility. The implementation prioritizes terminal-notifier for richer notifications and automatically falls back to AppleScript when it's unavailable.
- Adds terminal-notifier support for macOS notifications with custom icons and enhanced features
- Implements comprehensive fallback mechanism from terminal-notifier to osascript
- Includes extensive test coverage and detailed documentation for cross-platform system notifications
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/integrations/notifications/index.ts | Adds terminal-notifier support with fallback to osascript for macOS notifications |
| src/integrations/notifications/tests/index.spec.ts | Comprehensive test suite covering terminal-notifier, fallback scenarios, and cross-platform notifications |
| apps/kilocode-docs/docs/features/system-notifications.md | Detailed documentation for system notifications setup across macOS, Windows, and Linux |
| apps/kilocode-docs/sidebars.ts | Adds system notifications to documentation navigation |
| jetbrains/host/package.json | Removes unused watch scripts |
| .vscode/tasks.json | Updates watch task configuration for better package.json monitoring |
| .changeset/spicy-animals-nail.md | Documents the terminal notifier feature addition |
| args.push("-sound", "Tink") | ||
|
|
||
| // Add Kilo Code logo | ||
| const extensionUri = vscode.extensions.getExtension(`kilocode.kilo-code`)!.extensionUri |
There was a problem hiding this comment.
This line adds Kilocode-specific functionality but is missing the required kilocode_change comment marking. According to the coding guidelines, all Kilocode-specific changes should be marked with // kilocode_change at the end of the line.
Copilot generated this review using guidance from repository custom instructions.
|
|
||
| // Add Kilo Code logo | ||
| const extensionUri = vscode.extensions.getExtension(`kilocode.kilo-code`)!.extensionUri | ||
| const iconPath = vscode.Uri.joinPath(extensionUri, "assets", "icons", "kilo.png").fsPath |
There was a problem hiding this comment.
This line adds Kilocode-specific functionality but is missing the required kilocode_change comment marking. According to the coding guidelines, all Kilocode-specific changes should be marked with // kilocode_change at the end of the line.
Copilot generated this review using guidance from repository custom instructions.
| // Add Kilo Code logo | ||
| const extensionUri = vscode.extensions.getExtension(`kilocode.kilo-code`)!.extensionUri | ||
| const iconPath = vscode.Uri.joinPath(extensionUri, "assets", "icons", "kilo.png").fsPath | ||
| args.push("-appIcon", iconPath) |
There was a problem hiding this comment.
This line adds Kilocode-specific functionality but is missing the required kilocode_change comment marking. According to the coding guidelines, all Kilocode-specific changes should be marked with // kilocode_change at the end of the line.
Copilot generated this review using guidance from repository custom instructions.
Context
This PR adds enhanced macOS notification support with terminal-notifier integration while maintaining backward compatibility. The implementation prioritizes terminal-notifier for richer notifications and automatically falls back to AppleScript when it's unavailable.
Implementation
Screenshots