Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Rpi 40pin poe #1853

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Rpi 40pin poe #1853

wants to merge 13 commits into from

Conversation

jstjst
Copy link
Contributor

@jstjst jstjst commented May 14, 2019

Symbols for RPi 3B+ with PoE:
RaspberryPi-3B+_Run_PEN_PoE
RaspberryPi-3B+_PoE
grafik

@jstjst
Copy link
Contributor Author

jstjst commented May 14, 2019

@myfreescalewebpage As you can see at the commit messages, I first forgot to change the pin numbers for the PoE pins. I noticed that while doing the screenshot, but submitted the PR first and changed it immediately after that.
So I would expect to see an pin duplicated error in this Travis output: https://travis-ci.org/KiCad/kicad-symbols/builds/532551795?utm_source=github_status&utm_medium=notification
I had a look at the files and there are clearly pin duplicates (eg Line 924 and 925): d02267e

I'm just wondering what went wrong with the Travis check, because I saw it working here: https://travis-ci.org/KiCad/kicad-symbols/builds/528433497?utm_source=github_status&utm_medium=notification

@myfreescalewebpage myfreescalewebpage self-assigned this May 15, 2019
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging labels May 15, 2019
@myfreescalewebpage
Copy link
Collaborator

@jstjst no comment to do on the PR here.
I do not understood clearly waht you point in your previous message but seems the last commit on each of the PR are correct.
Joel

@jstjst jstjst mentioned this pull request May 15, 2019
@jstjst
Copy link
Contributor Author

jstjst commented May 15, 2019 via email

@jstjst
Copy link
Contributor Author

jstjst commented Dec 30, 2019

‼️ The PoE pins should be double check, as stated here: KiCad/kicad-footprints#2024 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants