Emit select for out-of-range builtin var indices #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
force-pushed
the
builtin-out-of-range
branch
from
9f86231 to
bed1a60
Compare
MrSidims
approved these changes
Feb 24, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638
svenvh
force-pushed
the
builtin-out-of-range
branch
from
bed1a60 to
b95d5d2
Compare
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
haonanya1
pushed a commit
to haonanya1/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes KhronosGroup#2638 .
svenvh
added a commit
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes #2638 .
svenvh
added a commit
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes #2638 .
MrSidims
pushed a commit
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes #2638 .
MrSidims
pushed a commit
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes #2638 .
MrSidims
pushed a commit
that referenced
this pull request
Mar 6, 2025
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example, `get_global_size` must return 1 if its argument is larger than `get_work_dim() - 1`. Ensure the generated `extractelement` index never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin). Fixes #2638 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour for out-of-range dimension arguments to work-item functions is well defined in OpenCL C. For example,
get_global_sizemust return 1 if its argument is larger thanget_work_dim() - 1.Ensure the generated
extractelementindex never exceeds the vector size and return the correct out-of-range value (which is either 0 or 1 depending on the builtin).Fixes #2638 .