remove GL_EXT_direct_state_access from some ES EXT extensions #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexaknyazev
reviewed
Mar 26, 2025
| Dependencies on GL_EXT_direct_state_access | ||
|
|
||
| If GL_EXT_direct_state_access is not supported, remove all references to | ||
| NamedBufferStorageEXT. |
There was a problem hiding this comment.
Please remove actual references to that function, starting from line 79.
There was a problem hiding this comment.
Whoops, fixed. I wonder if this should also modify the issues section where it mentions DSA.
There was a problem hiding this comment.
Yes. This is an ES-only extension so DSA does not exist here. Note that there are 11 references to that function in the extension text.
There was a problem hiding this comment.
Added another issue to document this.
internal issue 243
lexaknyazev
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal issue 243