Update more packages and stop auto-resolving peers (#1199)

## Summary:
This gets things up-to-date and addreses an issue with how peer deps are handled by pnpm.

- Latest TypeScript and @types/node added
- Removed some unneeded type libraries
- Updated jest and jest-when
- Stop autoresolving peer deps so that all packages use the same versions
- Updated various packages to address peer deps
- Update to latest pnpm
- Fix some docs generation warnings

Issue: FEI-7273

## Test plan:
`pnpm clean:all && pnpm i && pnpm test && pnpm typecheck && pnpm build && pnpm build:types && pnpm build:docs`

Author: somewhatabstract

Reviewers: kevinb-khan, somewhatabstract

Required Reviewers:

Approved By: kevinb-khan

Checks: ⌛ 1 check is pending, ✅ 6 checks were successful, ⏭️  1 check has been skipped

Pull Request URL: #1199

Author: somewhatabstract

.changeset/fuzzy-crabs-lie.md

@@ -0,0 +1,10 @@
+---
+"@khanacademy/wonder-stuff-logging": major
+"@khanacademy/wonder-stuff-testing": major
+"@khanacademy/wonder-stuff-sentry": major
+"@khanacademy/wonder-stuff-core": major
+"@khanacademy/wonder-stuff-ci": major
+"@khanacademy/ws-dev-build-settings": major
+---
+
+Update to TypeScript 5.9.x and other dependency changes

build-settings/check-type-definitions.ts

@@ -57,4 +57,6 @@ for (const typeDefinitionFile of typeDefinitionFiles) {
 
 if (foundErrors) {
     process.exit(1);
+} else {
+    console.log("All type imports are correct.");
 }

package.json

@@ -19,30 +19,27 @@
     "@changesets/cli": "^2.26.2",
     "@google-cloud/logging-winston": "^4.2.4",
     "@jest/globals": "^29.7.0",
-    "@rollup/plugin-babel": "^6.0.4",
+    "@rollup/plugin-babel": "^6.1.0",
     "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-replace": "^5.0.3",
     "@rollup/plugin-terser": "^0.4.4",
-    "@swc-node/register": "^1.10.10",
-    "@swc/core": "^1.3.93",
-    "@types/express": "^4.17.21",
-    "@types/express-winston": "^4.0.0",
-    "@types/jest": "^29.5.14",
+    "@swc-node/register": "^1.11.1",
+    "@swc/core": "^1.15.0",
+    "@types/jest": "^30.0.0",
     "@types/jest-when": "^3.5.5",
-    "@types/jsdom": "^21.1.1",
-    "@types/winston": "^2.4.4",
-    "@typescript-eslint/eslint-plugin": "8.17.0",
-    "@typescript-eslint/parser": "8.44.1",
-    "@typescript-eslint/rule-tester": "^8.17.0",
+    "@types/node": "^20.17.23",
+    "@typescript-eslint/eslint-plugin": "8.46.3",
+    "@typescript-eslint/parser": "8.46.3",
+    "@typescript-eslint/rule-tester": "^8.46.3",
     "ancesdir": "^7.1.1",
-    "babel-jest": "^29.7.0",
+    "babel-jest": "^30.2.0",
     "babel-watch": "^7.8.1",
-    "eslint": "^8.55.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.0.0",
-    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-disable": "^2.0.3",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest": "28.9.0",
     "eslint-plugin-jsdoc": "^58.1.1",
     "eslint-plugin-jsx-a11y": "^6.10.2",
@@ -51,19 +48,18 @@
     "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.33.2",
     "fast-glob": "^3.3.0",
-    "jest": "^29.7.0",
+    "jest": "^30.2.0",
     "jest-extended": "^6.0.0",
-    "jest-when": "^3.6.0",
-    "jsdom": "^21.1.1",
+    "jest-when": "^3.7.0",
     "npm-package-json-lint": "^8.0.0",
     "prettier": "^3.0.3",
     "rollup": "^4.50.2",
     "rollup-plugin-auto-external": "^2.0.0",
     "rollup-plugin-executable-output": "^1.3.0",
     "rollup-plugin-filesize": "^10.0.0",
     "rollup-plugin-preserve-shebangs": "^0.2.0",
-    "typedoc": "^0.27.9",
-    "typescript": "5.7.3",
+    "typedoc": "^0.28.14",
+    "typescript": "5.9.3",
     "winston": "^3.10.0"
   },
   "pnpm": {
@@ -98,5 +94,5 @@
     "typecheck": "tsc",
     "nochangeset": "pnpm changeset add --empty"
   },
-  "packageManager": "pnpm@10.6.5"
-}
+  "packageManager": "pnpm@10.20.0+sha512.cf9998222162dd85864d0a8102e7892e7ba4ceadebbf5a31f9c2fce48dfce317a9c53b9f6464d1ef9042cba2e02ae02a9f7c143a2b438cd93c91840f0192b9dd"
+}

packages/eslint-config-khan/package.json

@@ -16,17 +16,17 @@
     "license": "MIT",
     "peerDependencies": {
         "@khanacademy/eslint-plugin": "workspace:*",
-        "@typescript-eslint/eslint-plugin": "8.17.0",
-        "@typescript-eslint/parser": "8.17.0",
-        "eslint": "^8.55.0",
-        "eslint-config-prettier": "^8.3.0",
-        "eslint-import-resolver-typescript": "^3.5.3",
-        "eslint-plugin-import": "^2.23.4",
+        "@typescript-eslint/eslint-plugin": "8.46.3",
+        "@typescript-eslint/parser": "8.46.3",
+        "eslint": "^8.57.1",
+        "eslint-config-prettier": "^9.0.0",
+        "eslint-import-resolver-typescript": "^4.4.4",
+        "eslint-plugin-import": "^2.32.0",
         "eslint-plugin-jsx-a11y": "^6.10.2",
-        "eslint-plugin-prettier": "^3.4.0",
-        "eslint-plugin-react": "^7.24.0"
+        "eslint-plugin-prettier": "^5.0.1",
+        "eslint-plugin-react": "^7.33.2"
     },
     "devDependencies": {
-        "@typescript-eslint/rule-tester": "^8.17.0"
+        "@typescript-eslint/rule-tester": "^8.46.3"
     }
-}
+}

packages/eslint-plugin-khan/demo/package.json

@@ -9,8 +9,8 @@
   },
   "devDependencies": {
     "@khanacademy/eslint-plugin": "workspace:*",
-    "eslint": "^8.55.0",
-    "typescript": "^5.0.4"
+    "eslint": "^8.57.1",
+    "typescript": "5.9.3"
   },
   "dependencies": {
     "@types/react": "^18.2.6",

packages/eslint-plugin-khan/package.json

@@ -16,19 +16,19 @@
   "license": "MIT",
   "dependencies": {
     "@babel/types": "^7.23.0",
-    "@typescript-eslint/utils": "8.17.0",
+    "@typescript-eslint/utils": "8.46.3",
     "ancesdir": "^7.1.1",
     "checksync": "^10.0.2"
   },
   "devDependencies": {
     "@babel/eslint-parser": "^7.25.1",
     "@babel/preset-env": "^7.26.9",
     "@babel/preset-react": "^7.22.15",
-    "@swc-node/register": "^1.10.10",
-    "@swc/core": "^1.3.93",
-    "@typescript-eslint/rule-tester": "^8.17.0",
-    "eslint": "^8.55.0",
-    "prettier": "^2.8.8"
+    "@swc-node/register": "^1.11.1",
+    "@swc/core": "^1.15.0",
+    "@typescript-eslint/rule-tester": "^8.46.3",
+    "eslint": "^8.57.1",
+    "prettier": "^3.0.3"
   },
   "scripts": {
     "prettier": "prettier --write '{lib,test}/**/*.{js,ts}'"

packages/wonder-stuff-ci/package.json

@@ -30,7 +30,7 @@
         "@khanacademy/wonder-stuff-logging": "workspace:*"
     },
     "peerDependencies": {
-        "@google-cloud/logging-winston": "^4.1.1",
-        "winston": "^3.4.0"
+        "@google-cloud/logging-winston": "^4.2.4",
+        "winston": "^3.10.0"
     }
 }

packages/wonder-stuff-ci/src/extract-mobile-release-info-from-branch-name.ts

@@ -9,17 +9,17 @@ import type {MobileReleaseBranchInfo} from "./types";
  *    version: "7.8.0"
  * }
  *
- * @param {string} The release branch of the form `[release/[unified|ios|android]]/[v]<num>.<num>.<num>[-extra]`.
+ * @param {string} releaseBranch release branch of the form `[release/[unified|ios|android]]/[v]<num>.<num>.<num>[-extra]`.
  * @returns {MobileReleaseInfo} The release version and prefix, if found; otherwise, `null`.
  */
 export const extractMobileReleaseInfoFromBranchName = (
-    arg: string | null,
+    releaseBranch: string | null,
 ): MobileReleaseBranchInfo | null => {
-    if (!arg) {
+    if (!releaseBranch) {
         return null;
     }
 
-    const match = arg.match(
+    const match = releaseBranch.match(
         /^(release\/(ios|android|unified)\/)?v?(\d+\.\d+\.\d+(-\w*)*)$/i,
     );
     return match && match.length >= 3 && match[3]

packages/wonder-stuff-core/src/__tests__/__snapshots__/build-caused-by-message.test.ts.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`#buildCausedByMessage should default whitespace strings to (empty message) 1`] = `
 "(empty message)

packages/wonder-stuff-core/src/__tests__/__snapshots__/errors-from-error.test.ts.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`#errorsFromError should throw if the order is invalid 1`] = `"Invalid sequence order"`;