Skip to content

Commit 72be8b7

Browse files
Remove deps that we don't use (#1198)
## Summary: There are some deps that we had for our server-related packages, and those are gone. So should the deps be. This removes those dependencies that we no longer have use for. Also adds a `clean:all` command that does what `clean` used to, so we can still remove node_modules easily to clean up packages that have been removed as they can linger in there. Issue: FEI-7273 ## Test plan: `pnpm clean:all && pnpm i` `pnpm build` `pnpm test` Author: somewhatabstract Reviewers: somewhatabstract, kevinb-khan Required Reviewers: Approved By: kevinb-khan Checks: ✅ 7 checks were successful, ⏭️ 1 check has been skipped Pull Request URL: #1198
1 parent 31bd9f4 commit 72be8b7

File tree

5 files changed

+24
-1350
lines changed

5 files changed

+24
-1350
lines changed

.changeset/perfect-seals-knock.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@khanacademy/wonder-stuff-logging": major
3+
"@khanacademy/wonder-stuff-ci": major
4+
---
5+
6+
Remove unneeded peer deps

package.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@
1717
"@babel/preset-env": "^7.26.9",
1818
"@babel/preset-typescript": "^7.26.0",
1919
"@changesets/cli": "^2.26.2",
20-
"@google-cloud/kms": "^3.8.0",
2120
"@google-cloud/logging-winston": "^4.2.4",
22-
"@google-cloud/profiler": "^4.2.0",
23-
"@google-cloud/trace-agent": "^5.1.6",
2421
"@jest/globals": "^29.7.0",
2522
"@rollup/plugin-babel": "^6.0.4",
2623
"@rollup/plugin-node-resolve": "^15.2.3",
@@ -33,7 +30,6 @@
3330
"@types/jest": "^29.5.14",
3431
"@types/jest-when": "^3.5.5",
3532
"@types/jsdom": "^21.1.1",
36-
"@types/superagent": "^4.1.16",
3733
"@types/winston": "^2.4.4",
3834
"@typescript-eslint/eslint-plugin": "8.17.0",
3935
"@typescript-eslint/parser": "8.44.1",
@@ -54,9 +50,6 @@
5450
"eslint-plugin-prettier": "^5.0.1",
5551
"eslint-plugin-promise": "^6.1.1",
5652
"eslint-plugin-react": "^7.33.2",
57-
"express": "^4.21.2",
58-
"express-async-handler": "^1.2.0",
59-
"express-winston": "^4.2.0",
6053
"fast-glob": "^3.3.0",
6154
"jest": "^29.7.0",
6255
"jest-extended": "^6.0.0",
@@ -69,7 +62,6 @@
6962
"rollup-plugin-executable-output": "^1.3.0",
7063
"rollup-plugin-filesize": "^10.0.0",
7164
"rollup-plugin-preserve-shebangs": "^0.2.0",
72-
"superagent": "^5.3.1",
7365
"typedoc": "^0.27.9",
7466
"typescript": "5.7.3",
7567
"winston": "^3.10.0"
@@ -95,6 +87,7 @@
9587
"build:docs": "typedoc",
9688
"watch": "pnpm run rollup --watch",
9789
"clean": "rm -rf packages/*/dist && rm -f packages/*/*.tsbuildinfo",
90+
"clean:all": "pnpm run clean && rm -rf node_modules && rm -rf packages/*/node_modules",
9891
"coverage": "pnpm jest --coverage",
9992
"format": "prettier --write .",
10093
"lint": "pnpm run lint:ci .",
@@ -103,8 +96,7 @@
10396
"publish:ci": "pnpm run lint:pkg-json && node utils/pre-publish-check-ci.js && git diff --stat --exit-code HEAD && pnpm run build && pnpm run build:types && changeset publish",
10497
"test": "pnpm jest",
10598
"typecheck": "tsc",
106-
"nochangeset": "pnpm changeset add --empty",
107-
"add:devdepbysha": "bash -c 'pnpm add --workspace-root --save-dev \"git+https://[email protected]/Khan/$0.git#$1\"'"
99+
"nochangeset": "pnpm changeset add --empty"
108100
},
109101
"packageManager": "[email protected]"
110102
}

packages/wonder-stuff-ci/package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,7 @@
3030
"@khanacademy/wonder-stuff-logging": "workspace:*"
3131
},
3232
"peerDependencies": {
33-
"@google-cloud/kms": "^3.4.0",
3433
"@google-cloud/logging-winston": "^4.1.1",
35-
"@google-cloud/profiler": "^4.1.7",
36-
"@google-cloud/trace-agent": "^5.1.6",
37-
"express": "^4.17.2",
38-
"express-winston": "^4.2.0",
3934
"winston": "^3.4.0"
4035
}
4136
}

packages/wonder-stuff-logging/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"author": "",
2929
"license": "MIT",
3030
"peerDependencies": {
31-
"express-winston": "^4.2.0",
3231
"winston": "^3.4.0"
3332
}
3433
}

0 commit comments

Comments
 (0)